Incorrect behavior of DowngradeThrowExprRector

[defunctl]

Bug Report

Subject	Details
Rector version	last dev-main
Installed as	composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/f00e4092-b508-48dc-a41a-ebe1139e81a7

<?php declare(strict_types=1);

use \DB;
use \Repository_Exception;

final readonly class DemoFile
{
        private string $table = 'test';
    
	public function find( int $id ): array {
		return DB::table( $this->table )
			->where( 'id', $id )
			->get( ARRAY_A ) ?: throw new Repository_Exception( sprintf( 'Unable to find ID: %s', $id ) );
	}
}

Responsible rules

• DowngradeReadonlyPropertyRector

• DowngradeReadonlyClassRector

Expected Behavior

I believe the DowngradeThrowExprRector::refactorTernary() should have been used here?

[samsonasik]

Confirmed the error https://3v4l.org/koQgQ#v7.4.33

[defunctl]

Thanks @samsonasik!

Do you know which version this will be released in?

[samsonasik]

This should be included in next release, you can use dev-main while wait for that.

[defunctl]

@samsonasik I don't think this should run any statements twice and should instead find a way to assign a variable to a returned value?

For example, I am running database queries and throwing if something went wrong, which means my queries are being run twice once the code is downgraded.

Should I open a new issue?

[samsonasik]

That's out of scope of downgrade task, more and more we tweak language origin, that may cause unwanted bug, but feel free to create PR improvement for that on CallLike in ternary, or create your own custom rule for that :)

[samsonasik]

@defunctl Rector 1.1.1 tagged https://github.com/rectorphp/rector/releases/tag/1.1.1