V2 rc1 #22
Merged
V2 rc1 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
required fields are now specified first.
Create implies sending a POST to the Recurly API. New implies creation in memory.
Create implies sending a POST to the Recurly API. New implies creation in memory.
previous behavior of overwriting the existing object properties was incorrect also started multi-refund support
After an operation which rehydrates the Invoice, we were adding more Transactions to the Transactions collection. Now fixed.
Addons.Add(SubscriptionAddOn); Addons.Add(PlanAddOn); Addons.Add(plannAddOnCode);
maybe remove this test later. not really in our control.
Also now derives from System.Exception instead of ApplicationException. fixes #21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
account.CreateAdjustment()->account.NewAdjustment()to better describe that a call to the Recurly API does not occur.plan.CreateAddOn()->plan.NewAddOn()to better describe that a call to the Recurly API does not occur.invoice.Refund(invoice.Adjustments)subscription.ChangeSubscription()Subscription.TimeFrame.Nowis the default and no longer is required to be passed.subscription.AddOns.Add(). now supports:Recurly.Exception->Recurly.RecurlyExceptionto play nicer withSystem.ExceptionPlease rename Recurly.Exception! #21Recurly.RecurlyExceptionto inherit fromSystem.Exceptioninstead ofSystem.ApplicationExceptionPlease rename Recurly.Exception! #21