Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DOM state check to configure call #239

Closed
chrissrogers opened this issue Mar 7, 2016 · 6 comments
Closed

Add DOM state check to configure call #239

chrissrogers opened this issue Mar 7, 2016 · 6 comments
Assignees

Comments

@chrissrogers
Copy link
Member

configure should check the state of the stored fields and reset if the stored fields are no longer present.

Relevant Stack Overflow question

@patcoll
Copy link

patcoll commented Aug 29, 2016

@chrissrogers Any update on this? Currently developing a single-page app with Ember and am running up against this.

I see a parent option in configure. Is it possible to run configure again with parent: false to configure my form when it gets inserted into the DOM?

@chrissrogers
Copy link
Member Author

Hi @patcoll this is being addressed by #267

Multiple instances will allow destruction and re-instantiation of instances as desired. Once this goes in, however, I don't recommend doing so too much. Each instantiation requires each field to load an iframe, which incurs a noticeable load time. But it will allow for what you are requesting.

The parent option is used internally to track whether the r.js instance is running on the parent page or within an iframe.

@patcoll
Copy link

patcoll commented Aug 30, 2016

@chrissrogers Funny enough I was just discussing a potential reset() method with some of your engineers :) Hadn't seen that PR.

Great information about the parent option, thanks. I hadn't looked too deeply into what that was for.

I will use multiple instances for now and will wait for this to land. Cheers!

@chrissrogers
Copy link
Member Author

Closing since this is now incorporated into v4.3.0

@Mariusio
Copy link

@chrissrogers is 4.3.0 the version we will get if we use https://js.recurly.com/v4/recurly.js ?

@chrissrogers
Copy link
Member Author

@Maarius yep, you will always get the latest version via our CDN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants