Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] SDIM was not correctly implemented. #72

Closed
zhujiem opened this issue Oct 23, 2023 · 0 comments
Closed

[Bug] SDIM was not correctly implemented. #72

zhujiem opened this issue Oct 23, 2023 · 0 comments

Comments

@zhujiem
Copy link
Contributor

zhujiem commented Oct 23, 2023

  1. The model raises errors occasionally
  2. lsh_attention on long sequence has no mask for sequence padding positions
@xpai xpai closed this as completed in 60dc5f8 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant