Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Support for Color3s #38

Closed
ArchLand64 opened this issue Dec 31, 2023 · 0 comments · Fixed by #42
Closed

[FEAT] Support for Color3s #38

ArchLand64 opened this issue Dec 31, 2023 · 0 comments · Fixed by #42
Assignees
@sasial-dev
Labels
enhancement New feature or request
Milestone
0.5 Release

Comments

@ArchLand64
Copy link

Describe your feature

Zap should support the Color3 datatype.

Alternatives

Sending 3 doubles is less efficient than sending a single Color3.

Implementation Details

I think most people only need 8 bits of accuracy per color channel, but for HDR colors I guess you need to bump it to the next largest size which is 16 bits of accuracy per color channel. I would assume a Color3 channel range of [0, 1].
@ArchLand64 ArchLand64 added the enhancement New feature or request label Dec 31, 2023
@sasial-dev sasial-dev self-assigned this Jan 1, 2024
@sasial-dev sasial-dev mentioned this issue Jan 1, 2024
Merged
@sasial-dev sasial-dev added this to the 0.5 Release milestone Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sasial-dev sasial-dev

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.5 Release
Development

Successfully merging a pull request may close this issue.

Add Support for Color3 Type red-blox/zap
2 participants
@sasial-dev @ArchLand64