Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manual event loop option #47

Merged
merged 8 commits into from Jan 4, 2024
Merged

Conversation

nezuo
Copy link
Contributor

@nezuo nezuo commented Jan 2, 2024

Adds a manual_event_loop option which exports a send_events function when true. This is useful when the user can schedule send_events after all their other code that runs in the frame.

@nezuo nezuo marked this pull request as draft January 2, 2024 02:01
@nezuo
Copy link
Contributor Author

nezuo commented Jan 2, 2024

Making this a draft because it doesn't have documentation.

Copy link
Collaborator

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments

zap/src/output/luau/client.rs Outdated Show resolved Hide resolved
zap/src/output/luau/client.rs Outdated Show resolved Hide resolved
zap/src/output/luau/client.rs Show resolved Hide resolved
zap/src/output/luau/client.rs Outdated Show resolved Hide resolved
zap/src/output/luau/client.rs Outdated Show resolved Hide resolved
zap/src/output/luau/client.rs Outdated Show resolved Hide resolved
zap/src/output/luau/server.rs Outdated Show resolved Hide resolved
zap/src/output/luau/server.rs Outdated Show resolved Hide resolved
zap/src/output/luau/server.rs Outdated Show resolved Hide resolved
zap/src/output/luau/server.rs Show resolved Hide resolved
@sasial-dev sasial-dev added this to the 0.6 Release milestone Jan 2, 2024
@nezuo nezuo marked this pull request as ready for review January 2, 2024 23:55
@nezuo
Copy link
Contributor Author

nezuo commented Jan 2, 2024

Taking this out of draft mode now that there are docs. It still needs a warning about rate limiting the client but I'm not comfortable writing that section since I haven't tested that behavior myself.

Copy link
Collaborator

@sasial-dev sasial-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sasial-dev sasial-dev merged commit 8536b6e into red-blox:main Jan 4, 2024
2 checks passed
@nezuo nezuo deleted the manual-event-loop branch January 4, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants