Test Twilio Phone Verfication Database Insertion #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd assigned to variable output
…t creates a valid PhoneNumberVerification. The second checks the input against what gets placed into the database
… Added method to the PhoneNumberVerification class in models.py which takes in json input
gregziegan
reviewed
Mar 1, 2021
… with null carrier and the other has a null caller_name with a carrier. PhoneNumberVerification was given extra logic to account for when caller_name or carrier may be null. test_mock_twilio.py was goes through both of the mock json responses and adds them to the db
…ived within the carrier object. Added logic to account for if carrier is null. Adjusted repr to show phone_type instead of carrier_type. Adjusted tests to account for full carrier object.
gregziegan
changed the title
|
This will resolve #5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a test to ensure a mock JSON Twilio response can be saved as a valid PhoneNumberVerification entry. A second test was added that checks the input of the mock Twilio response to what is saved in the database.