Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor prometheus-configs to allow for PromTool unit testing #374

Open
ChristianZaccaria opened this issue Aug 3, 2023 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@ChristianZaccaria
Copy link

Issue

We would like to create and perform unit tests on the rules that are added. To achieve this, the simplest way is to make use of PromTool. PromTool requires the alerts to be in their own yaml file as the tool is not able to directly parse from the ConfigMap.

Possible Resolution

  • Move alerting-rules and possibly recording-rules from the ConfigMap to their own files.
  • Create Make target that makes use of PromTool to automatically run all tests.
  • Include a simple unit test to verify this new feature.
@ChristianZaccaria ChristianZaccaria added the enhancement New feature or request label Aug 3, 2023
@ChristianZaccaria ChristianZaccaria self-assigned this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant