forked from opendatahub-io/opendatahub-operator
-
Notifications
You must be signed in to change notification settings - Fork 8
/
upgrade.go
745 lines (680 loc) · 26 KB
/
upgrade.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
package upgrade
import (
"context"
"errors"
"fmt"
"reflect"
"strings"
"time"
"github.com/hashicorp/go-multierror"
operatorv1 "github.com/openshift/api/operator/v1"
routev1 "github.com/openshift/api/route/v1"
monitoringv1 "github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1"
appsv1 "k8s.io/api/apps/v1"
corev1 "k8s.io/api/core/v1"
authv1 "k8s.io/api/rbac/v1"
apiextv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
apierrs "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/api/meta"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/apimachinery/pkg/util/wait"
"sigs.k8s.io/controller-runtime/pkg/client"
kfdefv1 "github.com/opendatahub-io/opendatahub-operator/apis/kfdef.apps.kubeflow.org/v1"
dsc "github.com/opendatahub-io/opendatahub-operator/v2/apis/datasciencecluster/v1"
dsci "github.com/opendatahub-io/opendatahub-operator/v2/apis/dscinitialization/v1"
infrav1 "github.com/opendatahub-io/opendatahub-operator/v2/apis/infrastructure/v1"
"github.com/opendatahub-io/opendatahub-operator/v2/components"
"github.com/opendatahub-io/opendatahub-operator/v2/components/codeflare"
"github.com/opendatahub-io/opendatahub-operator/v2/components/dashboard"
"github.com/opendatahub-io/opendatahub-operator/v2/components/datasciencepipelines"
"github.com/opendatahub-io/opendatahub-operator/v2/components/kserve"
"github.com/opendatahub-io/opendatahub-operator/v2/components/kueue"
"github.com/opendatahub-io/opendatahub-operator/v2/components/modelmeshserving"
"github.com/opendatahub-io/opendatahub-operator/v2/components/ray"
"github.com/opendatahub-io/opendatahub-operator/v2/components/workbenches"
"github.com/opendatahub-io/opendatahub-operator/v2/pkg/cluster"
"github.com/opendatahub-io/opendatahub-operator/v2/pkg/deploy"
"github.com/opendatahub-io/opendatahub-operator/v2/pkg/gvk"
"github.com/opendatahub-io/opendatahub-operator/v2/pkg/metadata/labels"
)
type ResourceSpec struct {
Gvk schema.GroupVersionKind
Namespace string
// path to the field, like "metadata", "name"
Path []string
// set of values for the field to match object, any one matches
Values []string
}
// CreateDefaultDSC creates a default instance of DSC.
// Note: When the platform is not Managed, and a DSC instance already exists, the function doesn't re-create/update the resource.
func CreateDefaultDSC(ctx context.Context, cli client.Client) error {
// Set the default DSC name depending on the platform
releaseDataScienceCluster := &dsc.DataScienceCluster{
TypeMeta: metav1.TypeMeta{
Kind: "DataScienceCluster",
APIVersion: "datasciencecluster.opendatahub.io/v1",
},
ObjectMeta: metav1.ObjectMeta{
Name: "default-dsc",
},
Spec: dsc.DataScienceClusterSpec{
Components: dsc.Components{
Dashboard: dashboard.Dashboard{
Component: components.Component{ManagementState: operatorv1.Managed},
},
Workbenches: workbenches.Workbenches{
Component: components.Component{ManagementState: operatorv1.Managed},
},
ModelMeshServing: modelmeshserving.ModelMeshServing{
Component: components.Component{ManagementState: operatorv1.Managed},
},
DataSciencePipelines: datasciencepipelines.DataSciencePipelines{
Component: components.Component{ManagementState: operatorv1.Managed},
},
Kserve: kserve.Kserve{
Component: components.Component{ManagementState: operatorv1.Managed},
},
CodeFlare: codeflare.CodeFlare{
Component: components.Component{ManagementState: operatorv1.Managed},
},
Ray: ray.Ray{
Component: components.Component{ManagementState: operatorv1.Managed},
},
Kueue: kueue.Kueue{
Component: components.Component{ManagementState: operatorv1.Managed},
},
},
},
}
err := cli.Create(ctx, releaseDataScienceCluster)
switch {
case err == nil:
fmt.Printf("created DataScienceCluster resource\n")
case apierrs.IsAlreadyExists(err):
// Do not update the DSC if it already exists
fmt.Println("DataScienceCluster resource already exists. It will not be updated with default DSC.")
return nil
default:
return fmt.Errorf("failed to create DataScienceCluster custom resource: %w", err)
}
return nil
}
// createDefaultDSCI creates a default instance of DSCI
// If there exists an instance already, it patches the DSCISpec with default values
// Note: DSCI CR modifcations are not supported, as it is the initial prereq setting for the components.
func CreateDefaultDSCI(cli client.Client, _ deploy.Platform, appNamespace, monNamespace string) error {
defaultDsciSpec := &dsci.DSCInitializationSpec{
ApplicationsNamespace: appNamespace,
Monitoring: dsci.Monitoring{
ManagementState: operatorv1.Managed,
Namespace: monNamespace,
},
ServiceMesh: infrav1.ServiceMeshSpec{
ManagementState: "Managed",
ControlPlane: infrav1.ControlPlaneSpec{
Name: "data-science-smcp",
Namespace: "istio-system",
MetricsCollection: "Istio",
},
},
TrustedCABundle: dsci.TrustedCABundleSpec{
ManagementState: "Managed",
},
}
defaultDsci := &dsci.DSCInitialization{
TypeMeta: metav1.TypeMeta{
Kind: "DSCInitialization",
APIVersion: "dscinitialization.opendatahub.io/v1",
},
ObjectMeta: metav1.ObjectMeta{
Name: "default-dsci",
},
Spec: *defaultDsciSpec,
}
instances := &dsci.DSCInitializationList{}
if err := cli.List(context.TODO(), instances); err != nil {
return err
}
switch {
case len(instances.Items) > 1:
fmt.Println("only one instance of DSCInitialization object is allowed. Please delete other instances.")
return nil
case len(instances.Items) == 1:
// Do not patch/update if DSCI already exists.
fmt.Println("DSCInitialization resource already exists. It will not be updated with default DSCI.")
return nil
case len(instances.Items) == 0:
fmt.Println("create default DSCI CR.")
err := cli.Create(context.TODO(), defaultDsci)
if err != nil {
return err
}
}
return nil
}
func UpdateFromLegacyVersion(cli client.Client, platform deploy.Platform, appNS string, montNamespace string) error {
// If platform is Managed, remove Kfdefs and create default dsc
if platform == deploy.ManagedRhods {
fmt.Println("starting deletion of Deployment in managed cluster")
if err := deleteResource(cli, appNS, "deployment"); err != nil {
return err
}
// this is for the modelmesh monitoring part from v1 to v2
if err := deleteResource(cli, montNamespace, "deployment"); err != nil {
return err
}
if err := deleteResource(cli, montNamespace, "statefulset"); err != nil {
return err
}
if err := unsetOwnerReference(cli, "odh-dashboard-config", appNS); err != nil {
return err
}
// remove label created by previous v2 release which is problematic for Managed cluster
fmt.Println("removing labels on Operator Namespace")
operatorNamespace, err := cluster.GetOperatorNamespace()
if err != nil {
return err
}
if err := RemoveLabel(cli, operatorNamespace, "pod-security.kubernetes.io/enforce"); err != nil {
return err
}
fmt.Println("creating default DSC CR")
if err := CreateDefaultDSC(context.TODO(), cli); err != nil {
return err
}
return RemoveKfDefInstances(context.TODO(), cli)
}
if platform == deploy.SelfManagedRhods {
// remove label created by previous v2 release which is problematic for Managed cluster
fmt.Println("removing labels on Operator Namespace")
operatorNamespace, err := cluster.GetOperatorNamespace()
if err != nil {
return err
}
if err := RemoveLabel(cli, operatorNamespace, "pod-security.kubernetes.io/enforce"); err != nil {
return err
}
// If KfDef CRD is not found, we see it as a cluster not pre-installed v1 operator // Check if kfdef are deployed
kfdefCrd := &apiextv1.CustomResourceDefinition{}
if err := cli.Get(context.TODO(), client.ObjectKey{Name: "kfdefs.kfdef.apps.kubeflow.org"}, kfdefCrd); err != nil {
if apierrs.IsNotFound(err) {
// If no Crd found, return, since its a new Installation
// return empty list
return nil
}
return fmt.Errorf("error retrieving kfdef CRD : %w", err)
}
// If KfDef Instances found, and no DSC instances are found in Self-managed, that means this is an upgrade path from
// legacy version. Create a default DSC instance
kfDefList := &kfdefv1.KfDefList{}
err = cli.List(context.TODO(), kfDefList)
if err != nil {
return fmt.Errorf("error getting kfdef instances: : %w", err)
}
fmt.Println("starting deletion of Deployment in selfmanaged cluster")
if len(kfDefList.Items) > 0 {
if err = deleteResource(cli, appNS, "deployment"); err != nil {
return fmt.Errorf("error deleting deployment: %w", err)
}
// this is for the modelmesh monitoring part from v1 to v2
if err := deleteResource(cli, montNamespace, "deployment"); err != nil {
return err
}
if err := deleteResource(cli, montNamespace, "statefulset"); err != nil {
return err
}
// only for downstream since ODH has a different way to create this CR by dashboard
if err := unsetOwnerReference(cli, "odh-dashboard-config", appNS); err != nil {
return err
}
// create default DSC
if err = CreateDefaultDSC(context.TODO(), cli); err != nil {
return err
}
}
}
return nil
}
func getDashboardWatsonResources(ns string) []ResourceSpec {
metadataName := []string{"metadata", "name"}
specAppName := []string{"spec", "appName"}
appName := []string{"watson-studio"}
return []ResourceSpec{
{
Gvk: gvk.OdhQuickStart,
Namespace: ns,
Path: specAppName,
Values: appName,
},
{
Gvk: gvk.OdhDocument,
Namespace: ns,
Path: specAppName,
Values: appName,
},
{
Gvk: gvk.OdhApplication,
Namespace: ns,
Path: metadataName,
Values: appName,
},
}
}
// TODO: remove function once we have a generic solution across all components.
func CleanupExistingResource(ctx context.Context, cli client.Client, platform deploy.Platform, dscApplicationsNamespace, dscMonitoringNamespace string) error {
var multiErr *multierror.Error
// Special Handling of cleanup of deprecated model monitoring stack
if platform == deploy.ManagedRhods {
deprecatedDeployments := []string{"rhods-prometheus-operator"}
multiErr = multierror.Append(multiErr, deleteDeprecatedResources(ctx, cli, dscMonitoringNamespace, deprecatedDeployments, &appsv1.DeploymentList{}))
deprecatedStatefulsets := []string{"prometheus-rhods-model-monitoring"}
multiErr = multierror.Append(multiErr, deleteDeprecatedResources(ctx, cli, dscMonitoringNamespace, deprecatedStatefulsets, &appsv1.StatefulSetList{}))
deprecatedServices := []string{"rhods-model-monitoring"}
multiErr = multierror.Append(multiErr, deleteDeprecatedResources(ctx, cli, dscMonitoringNamespace, deprecatedServices, &corev1.ServiceList{}))
deprecatedRoutes := []string{"rhods-model-monitoring"}
multiErr = multierror.Append(multiErr, deleteDeprecatedResources(ctx, cli, dscMonitoringNamespace, deprecatedRoutes, &routev1.RouteList{}))
deprecatedSecrets := []string{"rhods-monitoring-oauth-config"}
multiErr = multierror.Append(multiErr, deleteDeprecatedResources(ctx, cli, dscMonitoringNamespace, deprecatedSecrets, &corev1.SecretList{}))
deprecatedClusterroles := []string{"rhods-namespace-read", "rhods-prometheus-operator"}
multiErr = multierror.Append(multiErr, deleteDeprecatedResources(ctx, cli, dscMonitoringNamespace, deprecatedClusterroles, &authv1.ClusterRoleList{}))
deprecatedClusterrolebindings := []string{"rhods-namespace-read", "rhods-prometheus-operator"}
multiErr = multierror.Append(multiErr, deleteDeprecatedResources(ctx, cli, dscMonitoringNamespace, deprecatedClusterrolebindings, &authv1.ClusterRoleBindingList{}))
deprecatedServiceAccounts := []string{"rhods-prometheus-operator"}
multiErr = multierror.Append(multiErr, deleteDeprecatedResources(ctx, cli, dscMonitoringNamespace, deprecatedServiceAccounts, &corev1.ServiceAccountList{}))
deprecatedServicemonitors := []string{"modelmesh-federated-metrics"}
multiErr = multierror.Append(multiErr, deleteDeprecatedServiceMonitors(ctx, cli, dscMonitoringNamespace, deprecatedServicemonitors))
}
// common logic for both self-managed and managed
deprecatedOperatorSM := []string{"rhods-monitor-federation2"}
multiErr = multierror.Append(multiErr, deleteDeprecatedServiceMonitors(ctx, cli, dscMonitoringNamespace, deprecatedOperatorSM))
// Remove deprecated opendatahub namespace(owned by kuberay)
multiErr = multierror.Append(multiErr, deleteDeprecatedNamespace(ctx, cli, "opendatahub"))
// Handling for dashboard Jupyterhub CR, see jira #443
JupyterhubApp := schema.GroupVersionKind{
Group: "dashboard.opendatahub.io",
Version: "v1",
Kind: "OdhApplication",
}
multiErr = multierror.Append(multiErr, removOdhApplicationsCR(ctx, cli, JupyterhubApp, "jupyterhub", dscApplicationsNamespace))
// to take a reference
toDelete := getDashboardWatsonResources(dscApplicationsNamespace)
multiErr = multierror.Append(multiErr, deleteResources(ctx, cli, &toDelete))
return multiErr.ErrorOrNil()
}
func deleteResources(ctx context.Context, c client.Client, resources *[]ResourceSpec) error {
var errors *multierror.Error
for _, res := range *resources {
err := deleteOneResource(ctx, c, res)
errors = multierror.Append(errors, err)
}
return errors.ErrorOrNil()
}
func deleteOneResource(ctx context.Context, c client.Client, res ResourceSpec) error {
list := &unstructured.UnstructuredList{}
list.SetGroupVersionKind(res.Gvk)
err := c.List(ctx, list, client.InNamespace(res.Namespace))
if err != nil {
if errors.Is(err, &meta.NoKindMatchError{}) {
fmt.Printf("Could not delete %v: CRD not found\n", res.Gvk)
return nil
}
return fmt.Errorf("failed to list %s: %w", res.Gvk.Kind, err)
}
for _, item := range list.Items {
item := item
v, ok, err := unstructured.NestedString(item.Object, res.Path...)
if err != nil {
return fmt.Errorf("failed to get field %v for %s %s/%s: %w", res.Path, res.Gvk.Kind, res.Namespace, item.GetName(), err)
}
if !ok {
return fmt.Errorf("unexisting path to delete: %v", res.Path)
}
for _, toDelete := range res.Values {
if v == toDelete {
err = c.Delete(ctx, &item)
if err != nil {
return fmt.Errorf("failed to delete %s %s/%s: %w", res.Gvk.Kind, res.Namespace, item.GetName(), err)
}
fmt.Println("Deleted object", item.GetName(), res.Gvk, "in namespace", res.Namespace)
}
}
}
return nil
}
func RemoveKfDefInstances(ctx context.Context, cli client.Client) error {
// Check if kfdef are deployed
kfdefCrd := &apiextv1.CustomResourceDefinition{}
err := cli.Get(ctx, client.ObjectKey{Name: "kfdefs.kfdef.apps.kubeflow.org"}, kfdefCrd)
if err != nil {
if apierrs.IsNotFound(err) {
// If no Crd found, return, since its a new Installation
return nil
}
return fmt.Errorf("error retrieving kfdef CRD : %w", err)
}
expectedKfDefList := &kfdefv1.KfDefList{}
err = cli.List(ctx, expectedKfDefList)
if err != nil {
return fmt.Errorf("error getting list of kfdefs: %w", err)
}
// Delete kfdefs
for _, kfdef := range expectedKfDefList.Items {
kfdef := kfdef
// Remove finalizer
updatedKfDef := &kfdef
updatedKfDef.Finalizers = []string{}
err = cli.Update(ctx, updatedKfDef)
if err != nil {
return fmt.Errorf("error removing finalizers from kfdef %v : %w", kfdef.Name, err)
}
err = cli.Delete(ctx, updatedKfDef)
if err != nil {
return fmt.Errorf("error deleting kfdef %v : %w", kfdef.Name, err)
}
}
return nil
}
func deleteDeprecatedResources(ctx context.Context, cli client.Client, namespace string, resourceList []string, resourceType client.ObjectList) error {
var multiErr *multierror.Error
listOpts := &client.ListOptions{Namespace: namespace}
if err := cli.List(ctx, resourceType, listOpts); err != nil {
multiErr = multierror.Append(multiErr, err)
}
items := reflect.ValueOf(resourceType).Elem().FieldByName("Items")
for i := 0; i < items.Len(); i++ {
item := items.Index(i).Addr().Interface().(client.Object) //nolint:errcheck,forcetypeassert
for _, name := range resourceList {
if name == item.GetName() {
fmt.Printf("Attempting to delete %s in namespace %s\n", item.GetName(), namespace)
err := cli.Delete(ctx, item)
if err != nil {
if apierrs.IsNotFound(err) {
fmt.Printf("Could not find %s in namespace %s\n", item.GetName(), namespace)
} else {
multiErr = multierror.Append(multiErr, err)
}
}
fmt.Printf("Successfully deleted %s\n", item.GetName())
}
}
}
return multiErr.ErrorOrNil()
}
// Need to handle ServiceMonitor deletion separately as the generic function does not work for ServiceMonitors because of how the package is built.
func deleteDeprecatedServiceMonitors(ctx context.Context, cli client.Client, namespace string, resourceList []string) error {
var multiErr *multierror.Error
listOpts := &client.ListOptions{Namespace: namespace}
servicemonitors := &monitoringv1.ServiceMonitorList{}
if err := cli.List(ctx, servicemonitors, listOpts); err != nil {
multiErr = multierror.Append(multiErr, err)
}
for _, servicemonitor := range servicemonitors.Items {
servicemonitor := servicemonitor
for _, name := range resourceList {
if name == servicemonitor.Name {
fmt.Printf("Attempting to delete %s in namespace %s\n", servicemonitor.Name, namespace)
err := cli.Delete(ctx, servicemonitor)
if err != nil {
if apierrs.IsNotFound(err) {
fmt.Printf("Could not find %s in namespace %s\n", servicemonitor.Name, namespace)
} else {
multiErr = multierror.Append(multiErr, err)
}
}
fmt.Printf("Successfully deleted %s\n", servicemonitor.Name)
}
}
}
return multiErr.ErrorOrNil()
}
func removOdhApplicationsCR(ctx context.Context, cli client.Client, gvk schema.GroupVersionKind, instanceName string, applicationNS string) error {
// first check if CRD in cluster
crd := &apiextv1.CustomResourceDefinition{}
if err := cli.Get(ctx, client.ObjectKey{Name: "odhapplications.dashboard.opendatahub.io"}, crd); err != nil {
return client.IgnoreNotFound(err)
}
// then check if CR in cluster to delete
odhObject := &unstructured.Unstructured{}
odhObject.SetGroupVersionKind(gvk)
if err := cli.Get(ctx, client.ObjectKey{
Namespace: applicationNS,
Name: instanceName,
}, odhObject); err != nil {
return client.IgnoreNotFound(err)
}
if err := cli.Delete(ctx, odhObject); err != nil {
return fmt.Errorf("error deleting CR %s : %w", instanceName, err)
}
return nil
}
func unsetOwnerReference(cli client.Client, instanceName string, applicationNS string) error {
OdhDashboardConfig := schema.GroupVersionKind{
Group: "opendatahub.io",
Version: "v1alpha",
Kind: "OdhDashboardConfig",
}
crd := &apiextv1.CustomResourceDefinition{}
if err := cli.Get(context.TODO(), client.ObjectKey{Name: "odhdashboardconfigs.opendatahub.io"}, crd); err != nil {
return client.IgnoreNotFound(err)
}
odhObject := &unstructured.Unstructured{}
odhObject.SetGroupVersionKind(OdhDashboardConfig)
if err := cli.Get(context.TODO(), client.ObjectKey{
Namespace: applicationNS,
Name: instanceName,
}, odhObject); err != nil {
return client.IgnoreNotFound(err)
}
if odhObject.GetOwnerReferences() != nil {
// set to nil as updates
odhObject.SetOwnerReferences(nil)
if err := cli.Update(context.TODO(), odhObject); err != nil {
return fmt.Errorf("error unset ownerreference for CR %s : %w", instanceName, err)
}
}
return nil
}
func deleteResource(cli client.Client, namespace string, resourceType string) error {
// In v2, Deployment selectors use a label "app.opendatahub.io/<componentName>" which is
// not present in v1. Since label selectors are immutable, we need to delete the existing
// deployments and recreated them.
// because we can't proceed if a deployment is not deleted, we use exponential backoff
// to retry the deletion until it succeeds
var err error
switch resourceType {
case "deployment":
err = wait.ExponentialBackoffWithContext(context.TODO(), wait.Backoff{
// 5, 10, ,20, 40 then timeout
Duration: 5 * time.Second,
Factor: 2.0,
Jitter: 0.1,
Steps: 4,
Cap: 1 * time.Minute,
}, func(ctx context.Context) (bool, error) {
done, err := deleteDeploymentsAndCheck(ctx, cli, namespace)
return done, err
})
case "statefulset":
err = wait.ExponentialBackoffWithContext(context.TODO(), wait.Backoff{
// 10, 20 then timeout
Duration: 10 * time.Second,
Factor: 2.0,
Jitter: 0.1,
Steps: 2,
Cap: 1 * time.Minute,
}, func(ctx context.Context) (bool, error) {
done, err := deleteStatefulsetsAndCheck(ctx, cli, namespace)
return done, err
})
}
return err
}
func deleteDeploymentsAndCheck(ctx context.Context, cli client.Client, namespace string) (bool, error) {
// Delete Deployment objects
var multiErr *multierror.Error
deployments := &appsv1.DeploymentList{}
listOpts := &client.ListOptions{
Namespace: namespace,
}
if err := cli.List(ctx, deployments, listOpts); err != nil {
return false, nil //nolint:nilerr
}
// filter deployment which has the new label to limit that we do not overkill other deployment
// this logic can be used even when upgrade from v2.4 to v2.5 without remove it
markedForDeletion := []appsv1.Deployment{}
for _, deployment := range deployments.Items {
deployment := deployment
v2 := false
selectorLabels := deployment.Spec.Selector.MatchLabels
for label := range selectorLabels {
if strings.Contains(label, labels.ODHAppPrefix) {
// this deployment has the new label, this is a v2 to v2 upgrade
// there is no need to recreate it, as labels are matching
v2 = true
continue
}
}
if !v2 {
markedForDeletion = append(markedForDeletion, deployment)
multiErr = multierror.Append(multiErr, cli.Delete(ctx, &deployment))
}
}
for _, deployment := range markedForDeletion {
deployment := deployment
if e := cli.Get(ctx, client.ObjectKey{
Namespace: namespace,
Name: deployment.Name,
}, &deployment); e != nil {
if apierrs.IsNotFound(e) {
// resource has been successfully deleted
continue
}
// unexpected error, report it
multiErr = multierror.Append(multiErr, e) //nolint:staticcheck,wastedassign
}
// resource still exists, wait for it to be deleted
return false, nil
}
return true, multiErr.ErrorOrNil()
}
func deleteStatefulsetsAndCheck(ctx context.Context, cli client.Client, namespace string) (bool, error) {
// Delete statefulset objects
var multiErr *multierror.Error
statefulsets := &appsv1.StatefulSetList{}
listOpts := &client.ListOptions{
Namespace: namespace,
}
if err := cli.List(ctx, statefulsets, listOpts); err != nil {
return false, nil //nolint:nilerr
}
// even only we have one item to delete to avoid nil point still use range
markedForDeletion := []appsv1.StatefulSet{}
for _, statefulset := range statefulsets.Items {
v2 := false
statefulset := statefulset
selectorLabels := statefulset.Spec.Selector.MatchLabels
for label := range selectorLabels {
if strings.Contains(label, labels.ODHAppPrefix) {
v2 = true
continue
}
}
if !v2 {
markedForDeletion = append(markedForDeletion, statefulset)
multiErr = multierror.Append(multiErr, cli.Delete(ctx, &statefulset))
}
}
for _, statefulset := range markedForDeletion {
statefulset := statefulset
if e := cli.Get(ctx, client.ObjectKey{
Namespace: namespace,
Name: statefulset.Name,
}, &statefulset); e != nil {
if apierrs.IsNotFound(e) {
// resource has been successfully deleted
continue
}
// unexpected error, report it
multiErr = multierror.Append(multiErr, e)
} else {
// resource still exists, wait for it to be deleted
return false, nil
}
}
return true, multiErr.ErrorOrNil()
}
func RemoveDeprecatedTrustyAI(cli client.Client, platform deploy.Platform) error {
existingDSCList := &dsc.DataScienceClusterList{}
err := cli.List(context.TODO(), existingDSCList)
if err != nil {
return fmt.Errorf("error getting existing DSC: %w", err)
}
switch len(existingDSCList.Items) {
case 0:
return nil
case 1:
existingDSC := existingDSCList.Items[0]
if platform == deploy.ManagedRhods || platform == deploy.SelfManagedRhods {
if existingDSC.Spec.Components.TrustyAI.ManagementState != operatorv1.Removed {
existingDSC.Spec.Components.TrustyAI.ManagementState = operatorv1.Removed
err := cli.Update(context.TODO(), &existingDSC)
if err != nil {
return fmt.Errorf("error updating TrustyAI component: %w", err)
}
}
}
}
return nil
}
func RemoveLabel(cli client.Client, objectName string, labelKey string) error {
foundNamespace := &corev1.Namespace{}
if err := cli.Get(context.TODO(), client.ObjectKey{Name: objectName}, foundNamespace); err != nil {
if apierrs.IsNotFound(err) {
return nil
}
return fmt.Errorf("could not get %s namespace: %w", objectName, err)
}
delete(foundNamespace.Labels, labelKey)
if err := cli.Update(context.TODO(), foundNamespace); err != nil {
return fmt.Errorf("error removing %s from %s : %w", labelKey, objectName, err)
}
return nil
}
func deleteDeprecatedNamespace(ctx context.Context, cli client.Client, namespace string) error {
foundNamespace := &corev1.Namespace{}
if err := cli.Get(ctx, client.ObjectKey{Name: namespace}, foundNamespace); err != nil {
if apierrs.IsNotFound(err) {
return nil
}
return fmt.Errorf("could not get %s namespace: %w", namespace, err)
}
// Check if namespace is owned by DSC
isOwnedByDSC := false
for _, owner := range foundNamespace.OwnerReferences {
if owner.Kind == "DataScienceCluster" {
isOwnedByDSC = true
}
}
if !isOwnedByDSC {
return nil
}
// Check if namespace has pods running
podList := &corev1.PodList{}
listOpts := []client.ListOption{
client.InNamespace(namespace),
}
if err := cli.List(ctx, podList, listOpts...); err != nil {
return fmt.Errorf("error getting pods from namespace %s: %w", namespace, err)
}
if len(podList.Items) != 0 {
fmt.Printf("Skip deletion of namespace %s due to running Pods in it\n", namespace)
return nil
}
// Delete namespace if no pods found
if err := cli.Delete(ctx, foundNamespace); err != nil {
return fmt.Errorf("could not delete %s namespace: %w", namespace, err)
}
return nil
}