Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate properties from markup #36

Open
TheJaredWilcurt opened this issue Oct 28, 2020 · 1 comment
Open

Remove duplicate properties from markup #36

TheJaredWilcurt opened this issue Oct 28, 2020 · 1 comment
Labels
blocked Waiting on another issue to be resolved enhancement New feature or request help wanted Extra attention is needed
Projects

Comments

@TheJaredWilcurt
Copy link
Member

This would be handled by a top level boolean on a task ({ removeDuplicateProperties: true }).

Currently this

.cow {
    padding: 4px;
}
.dog {
    padding: 8px;
}
<div class="dog cow"></div>

outputs this

.rp__padding__--COLON4px { padding: 4px; }
.rp__padding__--COLON8px { padding: 8px; }
<div class="rp__padding__--COLON8px rp__padding__--COLON4px"></div>

The actual outcome is the div will have a padding of 8px because that rule comes later in the CSS file.

It would be nice to automatically remove the rp__padding__--COLON4px from the markup if it isn't used. This would reduce the markup file size, and could also reduce the CSS size if we have a feature to remove unused CSS.

@TheJaredWilcurt TheJaredWilcurt added enhancement New feature or request help wanted Extra attention is needed labels Oct 28, 2020
@TheJaredWilcurt TheJaredWilcurt added this to Backlog in Red Perfume via automation Oct 28, 2020
@TheJaredWilcurt TheJaredWilcurt added the blocked Waiting on another issue to be resolved label Dec 26, 2021
@TheJaredWilcurt
Copy link
Member Author

Blocked by:

Once that feature is released, then this setting can be passed in to it from the task manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Waiting on another issue to be resolved enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Backlog
Red Perfume
  
Backlog
Development

No branches or pull requests

1 participant