Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to Asynchronous #73

Open
TheJaredWilcurt opened this issue Sep 6, 2021 · 0 comments
Open

Convert to Asynchronous #73

TheJaredWilcurt opened this issue Sep 6, 2021 · 0 comments
Labels
API Changes to the API blocker Prevents other issues from being started
Projects
Red Perfume

Comments

@TheJaredWilcurt
Copy link
Member

TheJaredWilcurt commented Sep 6, 2021 •
edited

Sadly, the moment you let one of those little promise monsters in, the whole place goes to hell. If only deasync was maintained and worked with promises, or if TC39 had just let things be and I could have lived a beautiful life of only callbacks.

  • Re-think usage of library as async
  • Re-write documentation around this approach
  • Change some implementations around this.

Things that can be async:

  • Use of fs for read/write (existsSync is probably fine)
  • html-minifier-terser
@TheJaredWilcurt TheJaredWilcurt mentioned this issue Sep 6, 2021
Draft
2 tasks
@TheJaredWilcurt TheJaredWilcurt added the blocker Prevents other issues from being started label Sep 6, 2021
@TheJaredWilcurt TheJaredWilcurt added this to Priority (prioritized) in Red Perfume Sep 6, 2021
@TheJaredWilcurt TheJaredWilcurt added the API Changes to the API label Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Changes to the API blocker Prevents other issues from being started
Projects
Red-Perfume Project
Status: Todo
Red Perfume
  
Priority (prioritized)
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TheJaredWilcurt