Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner margins & .site padding #17

Open
resonantdoghouse opened this issue Jun 19, 2019 · 0 comments
Open

Banner margins & .site padding #17

resonantdoghouse opened this issue Jun 19, 2019 · 0 comments

Comments

@resonantdoghouse
Copy link
Collaborator

It looks like you have 3rem of padding around the .site element which is causing your banner images to have some white space e.g. this page: https://rethink.van.cp.academy.red/charity/coalition-for-rainforest-nations-cfrn/

You can try moving the padding to target a different element however you can also try pulling the image out of the container with some negative margins e.g.

.charity-header {
    margin: -3rem -3rem 0 -3rem;
}

Typically negative margins can be considered a bad practice however for pulling images out of containers this trick is useful in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant