Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lets get type safe #42

Merged
merged 63 commits into from Nov 24, 2019
Merged

Lets get type safe #42

merged 63 commits into from Nov 24, 2019

Conversation

henryruhs
Copy link
Owner

No description provided.

@coveralls
Copy link

coveralls commented Nov 24, 2019

Pull Request Test Coverage Report for Build 500

  • 222 of 270 (82.22%) changed or added relevant lines in 41 files are covered.
  • 6 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+3.6%) to 58.159%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chroma_feedback/helper.py 7 8 87.5%
chroma_feedback/provider/appveyor/core.py 12 13 92.31%
chroma_feedback/provider/circle/core.py 8 9 88.89%
chroma_feedback/provider/github/core.py 8 9 88.89%
chroma_feedback/provider/gitlab/core.py 14 15 93.33%
chroma_feedback/consumer/razer_chroma/core.py 5 7 71.43%
chroma_feedback/consumer/thingm_blink/core.py 5 7 71.43%
chroma_feedback/provider/codeship/core.py 22 24 91.67%
chroma_feedback/provider/core.py 11 13 84.62%
chroma_feedback/provider/jenkins/core.py 7 9 77.78%
Files with Coverage Reduction New Missed Lines %
chroma_feedback/provider/codeship/normalize.py 1 72.73%
chroma_feedback/provider/github/normalize.py 1 72.73%
chroma_feedback/provider/jenkins/normalize.py 1 27.27%
chroma_feedback/provider/teamcity/normalize.py 1 27.27%
chroma_feedback/consumer/core.py 2 35.29%
Totals Coverage Status
Change from base Build 435: 3.6%
Covered Lines: 1668
Relevant Lines: 2868

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 498

  • 222 of 272 (81.62%) changed or added relevant lines in 41 files are covered.
  • 8 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+3.5%) to 57.994%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chroma_feedback/helper.py 7 8 87.5%
chroma_feedback/provider/appveyor/core.py 12 13 92.31%
chroma_feedback/provider/circle/core.py 8 9 88.89%
chroma_feedback/provider/github/core.py 8 9 88.89%
chroma_feedback/provider/gitlab/core.py 14 15 93.33%
chroma_feedback/consumer/razer_chroma/core.py 5 7 71.43%
chroma_feedback/consumer/thingm_blink/core.py 5 7 71.43%
chroma_feedback/provider/codeship/core.py 22 24 91.67%
chroma_feedback/provider/core.py 11 13 84.62%
chroma_feedback/provider/jenkins/core.py 7 9 77.78%
Files with Coverage Reduction New Missed Lines %
chroma_feedback/provider/appveyor/normalize.py 1 81.82%
chroma_feedback/provider/codeship/normalize.py 1 72.73%
chroma_feedback/provider/github/normalize.py 1 72.73%
chroma_feedback/provider/jenkins/normalize.py 1 27.27%
chroma_feedback/provider/teamcity/normalize.py 1 27.27%
chroma_feedback/provider/travis/normalize.py 1 72.73%
chroma_feedback/consumer/core.py 2 35.29%
Totals Coverage Status
Change from base Build 435: 3.5%
Covered Lines: 555
Relevant Lines: 957

💛 - Coveralls

@henryruhs henryruhs merged commit 3ac953c into master Nov 24, 2019
@henryruhs henryruhs deleted the lets-get-type-safe branch November 24, 2019 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants