Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-platform changes must be duplicated #92

Closed
ahogue-atlassian opened this issue Feb 27, 2018 · 3 comments
Closed

Cross-platform changes must be duplicated #92

ahogue-atlassian opened this issue Feb 27, 2018 · 3 comments

Comments

@ahogue-atlassian
Copy link
Contributor

With the current directory structure, any techniques that work on Windows, Mac, and Linux must be duplicated. This is cumbersome for when one of them changes, as then the other two must also be changed in the same way.

This could be addressed by making a Common directory which contains cross-platform resources. The READMEs in each of the OS-specific directories could then link back to resources in the Common directory.

@ghost
Copy link

ghost commented Feb 27, 2018

This is good feedback, we are working on some restructuring and I think we will incorporate some YAML that will let us tag things rather than putting them in tags similar to the way that Chris Gates has done in Metta.
https://github.com/uber-common/metta
I'll leave this open for now, until we have better guidance

@brianebeyer
Copy link
Collaborator

Hi @ahogue-atlassian - can you take a look at the new YAML spec for atomics and the contribution guide here? https://github.com/redcanaryco/atomic-red-team/blob/master/CONTRIBUTIONS.md

I think this is a good solution for keeping tests similar and keeping any supporting materials next to the test's definition. It also gives us the ability to use YAML merges to share config across tests in the same technique.

There are still cases where we'll want to share supporting materials across techniques, which I think we'll want to use git committed symlinks for.

Does the new structure resolve your original concern, or did we miss the mark?

@brianebeyer
Copy link
Collaborator

I believe this is fixed in YAML restructuring. @ahogue-atlassian, please reopen if that's not the case. We'd love your feedback on this-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants