Skip to content
This repository has been archived by the owner on Sep 18, 2018. It is now read-only.

Socialite broken in Firefox 35 #12

Open
Vilkku opened this issue Dec 31, 2014 · 2 comments
Open

Socialite broken in Firefox 35 #12

Vilkku opened this issue Dec 31, 2014 · 2 comments

Comments

@Vilkku
Copy link

Vilkku commented Dec 31, 2014

Using Firefox 35, it seems like Socialite does not work. I tried reinstalling Scoialite (1.5.2 from the other thread), but in the options menu there are no sites listed, and clicking any of the buttons on the options panel does nothing (i.e. clicking "add site" does nothing).

Originally posted on reddit: https://www.reddit.com/r/socialite/comments/2ogdi5/socialite_broken_in_firefox_35/

@rupertsteel
Copy link

The problem is with the function sortChildren in src/modules/utils/domUtils.jsm with the line let parentElement = curElement.parentNode; The fix is to either rename parentElement to something else or remove the let, but because I don't know javascript that well, I don't know which one should be used.

@Vilkku
Copy link
Author

Vilkku commented Jan 20, 2015

rupertsteel posted a pull request that fixes this issue: #13

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants