Utilize baseplate request tracing in activity gateway/service #11
Conversation
|
Going to fix the tests. D'oh! |
| @@ -30,6 +34,11 @@ factory = reddit_service_activitygateway:make_wsgi_app | |||
| metrics.namespace = activity_gateway | |||
| metrics.endpoint = | |||
|
|
|||
| ; request tracing | |||
| tracing.enabled = true | |||
There was a problem hiding this comment.
like on the puppet side, i think it'd be nicer to the user to just branch on whether or not the endpoint is defined or not rather than having a separate flag. this is consistent with the metrics client as well.
There was a problem hiding this comment.
I wanted to provide flexibility for turning on trace calculation and management without needing to specify an endpoint for it (e.g. still logging locally). See https://github.com/reddit/baseplate/blob/master/baseplate/diagnostics/tracing.py#L60 for where I already branch on whether an endpoint exists for remote recording.
There was a problem hiding this comment.
after IRL discussion we're going to let the tracing integration always be on; if the endpoint is undefined here it'll just log with the Baseplate NullRecorder
|
馃拝 nit, commit message subject line is too long ("...") super exciting to see this happening, nice! |
ckwang8128
force-pushed
the
feature/tracing-integration
branch
from
5ac7b18
to
c5438cc
Compare
|
Test failures will happen until we upload the new Baseplate package. 馃拠 |
|
馃悷 ! |
ckwang8128
force-pushed
the
feature/tracing-integration
branch
from
c5438cc
to
bf24e42
Compare
This enables basic span trace logging via Baseplate's tracing integration.
馃憮 @spladug