This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
adjust maxlength html input attr for username #1373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like password.html has a name input as well. |
|
Yeah, it has, but it didn't have maxLength before. I've added it now anyway. |
|
🐟 thanks, I'll get this merged. |
|
Merged as f72b11a. |
|
Thanks for this contribution. If you tell me your reddit username I can get you a trophy. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in sync with MAX_USERNAME_LENGTH in validator.py.
I checked templates folder, loginformwide.html and login.html is correctly '20'. No other mistakes found.
refer to inactive issue #1222 .