Don't filter NSFW reddits for API clients #526
Conversation
|
How does this pull request interact with #479? |
|
I don't think there should be any crossover, this is specifically for the subreddit-listing page (/reddits), whereas #479 seems to be related to listings of actual submissions inside subreddits. |
| if not c.over18: | ||
| # Always show NSFW to API users unless obey_over18=true in querystring | ||
| is_api_client = c.render_style in extensions.API_TYPES | ||
| if (not is_api_client and not c.over18) or (is_api_client and c.obey_over18): |
There was a problem hiding this comment.
In its current form, this appears to always filter out over18 if c.obey_over18 even if c.over18. Instead, it should probably read:
if not c.over18 and (not is_api_client or c.obey_over18):There was a problem hiding this comment.
Yeah, I guess it should actually test the thing that it's supposed to be obeying. Yours looks correct, I'll update it.
|
Due to fixing the bad query, this will no longer work as-is. I'm going to close this pull request. If you'd like to implement this functionality (which sounds good to me) in the |
No description provided.