Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

wiki: Ensure wiki page not found gives a 404. #699

Closed
wants to merge 2 commits into from
Closed

wiki: Ensure wiki page not found gives a 404. #699

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f5bbc7
wiki: Ensure wiki page not found gives a 404.
andre-d Feb 22, 2013
28440c3
wiki: Ensure users who cannot revise do not get a create link.
andre-d May 8, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 9 additions & 3 deletions r2/r2/controllers/wiki.py
View file
Open in desktop
Expand Up @@ -105,9 +105,15 @@ def GET_wiki_page(self, pv, page_name):
page, version, version2 = pv page, version, version2 = pv


if not page: if not page:
if c.render_style in extensions.API_TYPES: is_api = c.render_style in extensions.API_TYPES
self.handle_error(404, 'PAGE_NOT_CREATED') if this_may_revise():
return WikiNotFound(page=page_name).render() if is_api:
self.handle_error(404, 'PAGE_NOT_CREATED')
errorpage = WikiNotFound(page=page_name)
request.environ['usable_error_content'] = errorpage.render()
elif is_api:
self.handle_error(404, 'PAGE_NOT_FOUND')
self.abort404()


if version: if version:
edit_by = version.get_author() edit_by = version.get_author()
Expand Down