-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on_change if's with nested properties #122
Comments
Yes, the conditional logic only works against the top level. I can think of two possible enhancements for this:
Interested in implementing either of these? |
Gotcha. Yeah, I actually found that spot in the code but wasn't sure if I was missing something else. Thanks! |
Using mango selectors would be a cool idea, but the current design takes a single _changes feed per database and then checks all on_change docs. In order to support mango selectors you'd need a feed per on_change and this would definitely increase the complexity of the change-listeners. I don't think that adding this complexity now is worth the trouble and it could actually lead to a lot of latency. I still think using sift would be the cleanest enhancement for now. |
Good point. It seems that avoiding unneeded complexity and latency would be a good idea. I'll have to keep my work around simple for the now given lack of time, but if I can I'll take a deeper look into sift. Thanks! |
given a document:
I can create an on_change doc that has:
these will work fine. However if I try:
this doesn't seem to work.
are the if's only meant to work against the top-level properties of the documents?
The text was updated successfully, but these errors were encountered: