Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Extra args" input #22

Closed
tetchel opened this issue Jan 26, 2021 · 2 comments · Fixed by #53
Closed

"Extra args" input #22

tetchel opened this issue Jan 26, 2021 · 2 comments · Fixed by #53
Assignees
Labels
enhancement New feature or request
Projects

Comments

@tetchel
Copy link
Contributor

tetchel commented Jan 26, 2021

Presently, if there is some option the user wants to pass to buildah that we don't have an input for, they are out of luck.

Tekton solves this problem with an "extra args" option that the user can put any extra args they like into and they are just appended to the buildah command.

https://github.com/tektoncd/catalog/blob/master/task/buildah/0.2/buildah.yaml

@tetchel
Copy link
Contributor Author

tetchel commented Feb 1, 2021

because of the way we have to run many commands in the non-dockerfile case, this does not work as well as I thought it would. after discussion with divyanshu, we are not going to implement this.

@tetchel tetchel closed this as completed Feb 1, 2021
@divyansh42
Copy link
Member

I think we should do this for build with dockerfile case, as it seems to be genuine requirement.

@divyansh42 divyansh42 reopened this Apr 7, 2021
@divyansh42 divyansh42 added this to To do in Sprint 199 Apr 7, 2021
@divyansh42 divyansh42 moved this from To do to In progress in Sprint 199 Apr 12, 2021
@divyansh42 divyansh42 moved this from In progress to Done in Sprint 199 Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
2 participants