Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sanity test as an workflow #8

Closed
divyansh42 opened this issue Nov 19, 2020 · 1 comment · Fixed by #11
Closed

Add Sanity test as an workflow #8

divyansh42 opened this issue Nov 19, 2020 · 1 comment · Fixed by #11
Assignees
@divyansh42

Comments

@divyansh42
Copy link
Member

This action is lacking the testing mechanism. If there is some update in code or new feature got added that may contain few bugs.
So to ensure the changes being done is as desired, a testing mechanism would be helpful.
@divyansh42 divyansh42 self-assigned this Nov 19, 2020
@divyansh42
Copy link
Member Author

Can be done similar to: https://github.com/redhat-actions/s2i-build/blob/main/.github/workflows/verify-build.yml

@divyansh42 divyansh42 mentioned this issue Nov 19, 2020
Merged
@divyansh42 divyansh42 linked a pull request Nov 23, 2020 that will close this issue
Add tests #11
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@divyansh42 divyansh42

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests
1 participant
@divyansh42