Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove label checks from "Surface-level tests" #177

Open
lcarva opened this issue Jul 21, 2023 · 4 comments
Open

Remove label checks from "Surface-level tests" #177

lcarva opened this issue Jul 21, 2023 · 4 comments
Assignees

Comments

@lcarva
Copy link
Member

lcarva commented Jul 21, 2023

The label checks are moving. They are no longer considered a test. Instead, these checks will be performed by the Enterprise Contract. Let's remove them from being mentioned in the docs for surface-level tests.

cc @dirgim, @arewm

@gtrivedi88
Copy link
Collaborator

I'll update the docs for this issue. Sorry for the delay.

@gtrivedi88
Copy link
Collaborator

Hi @dirgim @arewm,
Do you think it would be sufficient to hide/remove this page from the output? Just trying to understand the scope of work.

@gtrivedi88 gtrivedi88 self-assigned this Aug 21, 2023
@arewm
Copy link
Contributor

arewm commented Aug 22, 2023

They can just be removed from the surface level checks as long as we still have appropriate coverage of their status/configuration elsewhere (i.e. wherever EC checks are documented).

@gtrivedi88
Copy link
Collaborator

gtrivedi88 commented Aug 22, 2023

@arewm The surface-level tests page only talks about Label checks. We have multiple tables under Label checks, but they all seem to be related to Label checks. So if I remove/hide them (the content), I don't see the value that the Surface-level tests page will offer. Therefore, do you think we can remove/hide the entire Surface-level tests page?

As for the EC checks, I'll review the Enterprise Contract documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants