Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor file watching #70

Closed
mathianasj opened this issue Jul 31, 2020 · 0 comments · Fixed by #82
Closed

Refactor file watching #70

mathianasj opened this issue Jul 31, 2020 · 0 comments · Fixed by #82
Assignees
@mathianasj
Labels
cleanup Refactor work and making code more maintainable good first issue Good for newcomers help wanted Extra attention is needed

Comments

@mathianasj
Copy link
Contributor

Right now we have almost copy/paste duplication of the file watcher for the systemCAFilename in

apiservice_controller.go
customresourcedefinition_controller.go
mutatingwebhookconfiguration_controller.go
validationwebhookconfiguration_controller.go

I would like to see this functionality abstracted out of these files and placed in a shared location.
@mathianasj mathianasj added cleanup Refactor work and making code more maintainable good first issue Good for newcomers help wanted Extra attention is needed labels Jul 31, 2020
@raffaelespazzoli raffaelespazzoli mentioned this issue Dec 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mathianasj mathianasj

Labels
cleanup Refactor work and making code more maintainable good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sdk 1.x raffaelespazzoli/cert-utils-operator
1 participant
@mathianasj