Use registry.redhat.io to load server and operator #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix default operator and server addresses to use registry.redhat.io by default.
dmytro-ndp
requested review from
benoitf,
l0rd,
rhopp and
vparfonov
as code owners
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
davidfestal
requested changes
Nov 21, 2019
ibuziuk
reviewed
Nov 21, 2019
There was a problem hiding this comment.
@dmytro-ndp AFAIK, README is updated automatically by npx, so need to update it manually cc: @benoitf
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
davidfestal
approved these changes
Nov 21, 2019
|
@ibuziuk: in that case it's strange that there are other commits regarding README.md, for example a12cc1f#diff-04c6e90faac2675aa89e2176d2eec7d8 |
|
@dmytro-ndp I mean someone need to run the command for update and than commit changes, but not fix the README manually. @benoitf could you please comment how this should be done? |
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>
|
Meanwhile I have restored README.md to unblock fixup. |
benoitf
approved these changes
Nov 22, 2019
|
Thank you, @benoitf ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix default operator and server addresses to use registry.redhat.io instead of quay.io by default.
Issue to be fixed
https://issues.jboss.org/browse/CRW-506