Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-nodejs-simple devfile #176

Merged
merged 1 commit into from Oct 11, 2019

Conversation

JPinkney
Copy link
Contributor

@JPinkney JPinkney commented Oct 8, 2019

This PR brings in the web-nodejs-simple devfile.

This devfile differs from the devfile in the che-devfile-registry in 2 ways:

  • Uses registry.redhat.io/codeready-workspaces/stacks-node-rhel8 which includes node 10
  • nodemon isn't available in the current version of the image so it has replaced all references of nodemon with node (though I believe @nickboldt is working on this so that this image has nodemon)

Signed-off-by: Josh Pinkney joshpinkney@gmail.com

@devstudio-release
Copy link
Contributor

crw_stable-branch_PR # 139: SUCCESS

@nickboldt
Copy link
Member

nickboldt commented Oct 10, 2019

So... weirdly, nodemon was already in the node 10 image... but it was returning version master: <none> from /usr/bin/nodemon

So I've pulled 1.19.3 here: redhat-developer/codeready-workspaces-deprecated@d557fcd

Building tarball here:

https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/CRW_CI/view/Pipelines/job/crw-operator-installer-and-ls-deps_master/

Will pull into docker image rebuild from here:

http://pkgs.devel.redhat.com/cgit/containers/codeready-workspaces-stacks-node/commit/?h=crw-2.0-rhel-8

New container build is done.

$➔ docker run -it --rm --entrypoint /bin/bash quay.io/crw/stacks-node-rhel8:2.0-3 -c "nodemon --version"
1.19.3

Try quay.io/crw/stacks-node-rhel8:2.0-3 or newer and let me know if nodemon works for you in there.

If you want to build a devfile registry including your PR, update to master and build from https://github.com/redhat-developer/codeready-workspaces/blob/master/dependencies/che-plugin-registry/Dockerfile

@JPinkney
Copy link
Contributor Author

@nickboldt Everything works as expected with that image :) 👍 Do you want me to push the changes using the quay image and then we change it to the red hat registry image when CRW2 is released?

@nickboldt
Copy link
Member

Yes, please update PR to use nodemon and latest quay image. We can flip these over to use reg.rh.io later when we're closer to GA.

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@JPinkney
Copy link
Contributor Author

@nickboldt Done!

@devstudio-release
Copy link
Contributor

crw_stable-branch_PR # 144: FAILURE

@nickboldt nickboldt merged commit bfea59b into redhat-developer:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants