Add dotnet, java maven and jboss devfiles #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickboldt it is ready to review |
|
If you update your PR to the latest in master you can then run a build:
And then use that devfile registry in your local Che to see how it behaves. Meanwhile I notice that the java-maven config is different from the upstream one:
Do we need the same JAVA_OPTS and JAVA_TOOL_OPTIONS? or are those only for JDK 11? Also are we sure redhat/java/latest will always be JDK 8? maybe it's better to use |
Signed-off-by: svor <vsvydenk@redhat.com>
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: svor vsvydenk@redhat.com
Adds several devfiles: