Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRW-586 add Quarkus devfile +... #223

Merged
merged 3 commits into from
Jan 31, 2020

Conversation

nickboldt
Copy link
Member

CRW-586 add Quarkus devfile + icon

Change-Id: I9f2fb6cde23ecf3eefa5d04e5b7b58cf04a5228a
Signed-off-by: nickboldt nboldt@redhat.com

@nickboldt
Copy link
Member Author

nickboldt commented Jan 25, 2020

Failed to load devfile in OCP 4.1 instance (as in #222) but in che.openshift.io it loaded OK from https://raw.githubusercontent.com/redhat-developer/codeready-workspaces/f02980e0699a57c86672b0e60abcb5a579bc9a0a/dependencies/che-devfile-registry/devfiles/03_java11-quarkus/devfile.yaml

image

We should probably tweak the sample project so the README.md doesn't mention JDK1.8+ (as the CRW version is for JDK11.0.6 embedded in GraalVM). Or use a different sample project?

WDYT @svor ?

@devstudio-release
Copy link
Contributor

crw_master_PR # 20: SUCCESS

@devstudio-release
Copy link
Contributor

crw_master_PR # 21: SUCCESS

@svor
Copy link
Contributor

svor commented Jan 27, 2020

@nickboldt
I tried native compilation in this devfile and got an error

[ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:1.1.1.Final:native-image (default) on project getting-started: Failed to generate a native image: Failed to augment application classes: Build failure: Build failed due to errors
[ERROR]         [error]: Build step io.quarkus.deployment.pkg.steps.NativeImageBuildStep#build threw an exception: java.lang.IllegalStateException: Unsupported version of GraalVM detected: GraalVM Version 19.3.1 CE. Please use GraalVM 19.2.1.

In https://github.com/quarkusio/quarkus/wiki/Migration-Guide-1.3 As I see GraalVM JDK 11 is a tech preview for now. So probably it isn't stable right now.
Also I found related issue quarkusio/quarkus#5682
And Quarkus guide says that we need GraalVM version 19.2.1 - https://quarkus.io/guides/building-native-image#prerequisites.

So probably for now we have to use Java-8 and GraalVM-19.2.1 to provide native compilation

@nickboldt
Copy link
Member Author

nickboldt commented Jan 27, 2020

Hmm, odd. https://github.com/quarkusio/quarkus/wiki/Migration-Guide-1.2 doesn't mention that JDK 11 is tech preview (and that's the version we have in the plugin registry).

But since Stevan has said that native isn't something we NEED for 2.1, I've opened https://issues.redhat.com/browse/CRW-611 as a future work item for Che 7.10+/CRW 2.2+.

I'm thinking I could remove the c++ stuff and reduce the container by a further 60MB. Or leave it because it's already over 690M :D

@tsmaeder tsmaeder removed their assignment Jan 30, 2020
@tsmaeder
Copy link
Contributor

@nickboldt since @svor did the upstream plugin, he's a much better reviewer than me. I can't request him, though.

@nickboldt
Copy link
Member Author

But you could have assigned it to him?

@nickboldt
Copy link
Member Author

nickboldt commented Jan 30, 2020

graalvm & c/c++ stuff removed. openjdk 11 added.

quay.io/crw/plugin-java11-rhel8:2.1-7

Change-Id: I9f2fb6cde23ecf3eefa5d04e5b7b58cf04a5228a
Signed-off-by: nickboldt <nboldt@redhat.com>
Change-Id: Iff973b43040fc0d3d2289020a23c20ac8caa3a37
Signed-off-by: nickboldt <nboldt@redhat.com>
…uarkus-java8/latest

Change-Id: Ifdb15b2071c8423dc2348cd6a70f59cfe8739887
Signed-off-by: nickboldt <nboldt@redhat.com>
@devstudio-release
Copy link
Contributor

crw_master_PR # 35: FAILURE

@nickboldt nickboldt merged commit 14ded8b into redhat-developer:master Jan 31, 2020
@devstudio-release
Copy link
Contributor

crw_master_PR # 36: FAILURE

@tsmaeder tsmaeder mentioned this pull request Feb 18, 2020
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants