Update commands' names #328
Conversation
Signed-off-by: svor <vsvydenk@redhat.com>
|
@Ohrimenko1988 @dmytro-ndp do some automated tests depend on commands's names in CRW? |
dependencies/che-devfile-registry/devfiles/03_vertx-http-booster/devfile.yaml
Outdated
Show resolved
Hide resolved
| actions: | ||
| - workdir: '${CHE_PROJECTS_ROOT}/vertx-http-booster' | ||
| type: exec | ||
| command: >- | ||
| MAVEN_OPTS="-Xmx200m" && mvn fabric8:deploy -Popenshift -DskipTests | ||
| -Dvertx.disableDnsResolver=true | ||
| component: maven | ||
| - name: Debug remote java application |
There was a problem hiding this comment.
@nickboldt I didn't edit debug configuration commands because they aren't displayed in workspace view, so i don't see any reason to make them numbered
There was a problem hiding this comment.
But for other devfiles you DID number the debug steps...
https://github.com/redhat-developer/codeready-workspaces/pull/328/files#diff-28f061010157f7b6d2b541508237c3cfR55
https://github.com/redhat-developer/codeready-workspaces/pull/328/files#diff-ff9994e6dff7b297cd1928e91f8bed5fR61
There was a problem hiding this comment.
I did it for Che commands which are displayed in workspace view:
The command which describes debug configuration has type vscode-launch which means that this configuration will be added into /projects/.theia/launch.json (it is NOT executable command)
And the name of this command is displayed only in devfile, it is not visible in workspace.
Could you explain what is the reason to have
There was a problem hiding this comment.
ah, apologies -- misunderstanding on my part w.r.t. command vs. config. :D
| actions: | ||
| - type: exec | ||
| component: dotnet | ||
| command: "dotnet build" | ||
| command: "dotnet run" | ||
| workdir: ${CHE_PROJECTS_ROOT}/dotnet-web-simple | ||
| - | ||
| name: Launch .NET Web Application on Debug mode |
There was a problem hiding this comment.
Should this be numbered too? Or if not, then at least changed to
Launch .net web application in debug mode
(to change from on to in, and be consistent with other "Initial upper case then lowercase" strings?)
Signed-off-by: svor vsvydenk@redhat.com
What does this PR do?
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-1046
https://issues.redhat.com/browse/CRW-1028