Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"odo component list --path" shows incorrect "STATE" when components belong to different projects #2032

Closed
dharmit opened this issue Aug 22, 2019 · 3 comments · Fixed by #2200
Closed

"odo component list --path" shows incorrect "STATE" when components belong to different projects #2032

dharmit opened this issue Aug 22, 2019 · 3 comments · Fixed by #2200
Assignees
@mik-dass
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Projects
Sprint 173
Milestone
1.0

Comments

@dharmit
Copy link
Member

dharmit commented Aug 22, 2019

[kind/bug]

What versions of software are you using?

  • Operating System: Fedora
  • Output of odo version: master

How did you run odo exactly?

  • Create two components belonging to different projects/namespaces
  • Push the components using odo push
  • Execute odo list --path ../ in the context directory of both components and observe the "STATE" column of the output
  • If the components belong to the same project, the output shows up as expected.

Actual behavior

  • Components belong to different projects 
    $ pwd
/home/dshah/src/nodejs-ex-2

$ odo list --path ../
APP     NAME                        TYPE       SOURCE     STATE          CONTEXT
app     nodejs-nodejs-ex-kyvs       nodejs     ./         Not Pushed     /home/dshah/src/nodejs-ex
app     nodejs-nodejs-ex-2-msky     nodejs     ./         Pushed         /home/dshah/src/nodejs-ex-2

$ pwd
/home/dshah/src/nodejs-ex

$ odo list --path ../
APP     NAME                        TYPE       SOURCE     STATE          CONTEXT
app     nodejs-nodejs-ex-kyvs       nodejs     ./         Pushed         /home/dshah/src/nodejs-ex
app     nodejs-nodejs-ex-2-msky     nodejs     ./         Not Pushed     /home/dshah/src/nodejs-ex-2
  • Components belong to same project 
    $ odo list --path ../
APP     NAME                        TYPE       SOURCE     STATE          CONTEXT
app     nodejs-nodejs-ex-kyvs       nodejs     ./         Pushed         /home/dshah/src/nodejs-ex
app     nodejs-nodejs-ex-2-msky     nodejs     ./         Pushed         /home/dshah/src/nodejs-ex-2

Expected behavior

Executing odo list --path ../ should present same output which should show the "STATE" as "Pushed".

$ odo list --path ../
APP     NAME                        TYPE       SOURCE     STATE          CONTEXT
app     nodejs-nodejs-ex-kyvs       nodejs     ./         Pushed         /home/dshah/src/nodejs-ex
app     nodejs-nodejs-ex-2-msky     nodejs     ./         Pushed      /home/dshah/src/nodejs-ex-2

Any logs, error output, etc?
@girishramnani girishramnani added the priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). label Aug 23, 2019
@kadel
Copy link
Member

kadel commented Sep 4, 2019

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 4, 2019
@kadel kadel added this to the 1.0 milestone Sep 4, 2019
@kadel kadel added this to For consideration in Sprint 172 via automation Sep 4, 2019
@girishramnani girishramnani added this to For consideration in Sprint 173 via automation Sep 23, 2019
@girishramnani girishramnani removed this from For consideration in Sprint 172 Sep 23, 2019
@girishramnani girishramnani moved this from For consideration to To do in Sprint 173 Sep 23, 2019
@mik-dass
Copy link
Contributor

mik-dass commented Sep 25, 2019 •
edited

I am facing this issue while running odo list --path <path>

[mrinaldas@localhost nodejs-ex]$ odo list --path /home/mrinaldas
 ✗  namespacing: component name cannot be blank

@kadel
Copy link
Member

kadel commented Sep 26, 2019

I am facing this issue while running odo list --path <path>

[mrinaldas@localhost nodejs-ex]$ odo list --path /home/mrinaldas
 ✗  namespacing: component name cannot be blank

confirmed, this is a bug. odo list with --path needs to work outside the context directory.

@kadel kadel mentioned this issue Sep 26, 2019
Closed
@mik-dass mik-dass mentioned this issue Sep 27, 2019
Merged
@mik-dass mik-dass moved this from To do to In progress in Sprint 173 Sep 27, 2019
@mik-dass mik-dass moved this from In progress to Ready for review in Sprint 173 Sep 30, 2019
Sprint 173 automation moved this from Ready for review to Done Oct 1, 2019
@amitkrout amitkrout mentioned this issue Oct 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mik-dass mik-dass

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Projects
No open projects
Sprint 173
  
Done
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Fixes odo list with path flag mik-dass/odo
5 participants
@kadel @dharmit @girishramnani @mik-dass @openshift-ci-robot