Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added -o json for storage creation / deletion / waiting #2055

Closed
cdrage opened this issue Aug 28, 2019 · 6 comments
Closed

Added -o json for storage creation / deletion / waiting #2055

cdrage opened this issue Aug 28, 2019 · 6 comments
Labels
area/json-output Issues or PRs related to JSON output (machine readable output) kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@cdrage
Copy link
Member

cdrage commented Aug 28, 2019

[kind/Enhancement]

Which functionality do you think we should update/improve?

Currently we use the below commands for VSCode for storage creation / deletion / waiting:

createStorage

odo storage create ${storageName} --path=${mountPath} --size=${storageSize} --project ${project} --app ${app} --component ${component}

deleteStorage

odo storage delete ${storage} -f --project ${project} --app ${app} --component ${component}

waitForStorageToBeGone

oc wait pvc/${storage}-${app}-pvc --for=delete --namespace ${project}

We need to implement the -o json parameter for each command's output.

Why is this needed?

Needed for json output / VSCode to consume said output.

@cdrage cdrage added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Aug 28, 2019
@cdrage cdrage self-assigned this Aug 28, 2019
@cdrage
Copy link
Member Author

cdrage commented Sep 9, 2019

This has actually already been implemented for odo create:

github.com/openshift/odo  add-service-listing-json ✔                                                                                                                                                                                                                                                                                                                    2d
▶ ./odo storage create mystorage --path=/opt/app-root/src/storage/ --size=1Gi -o json --context ~/nodejs-ex
{"kind":"storage","apiVersion":"odo.openshift.io/v1alpha1","metadata":{"name":"mystorage","creationTimestamp":null},"spec":{"size":"1Gi"},"status":{"path":"/opt/app-root/src/storage/"}}

@cdrage cdrage closed this as completed Sep 9, 2019
@cdrage cdrage reopened this Sep 9, 2019
@kadel
Copy link
Member

kadel commented Dec 5, 2019

/unassign @cdrage
/area json-output

@openshift-ci-robot openshift-ci-robot added the area/json-output Issues or PRs related to JSON output (machine readable output) label Dec 5, 2019
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 4, 2020
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 3, 2020
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link
Collaborator

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/json-output Issues or PRs related to JSON output (machine readable output) kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants