Removing --app, --project, --component from subcommands that depends on component dir

[amitkrout]

Copied from our last cabal discussion

• we should remove --project, --app, --component flags from url and storage

• we need to check with vscode adapter that they are not using it

• lets check if there are more commands where we need to remove those flags

[amitkrout]

/kind bug
/kind enhancement

[openshift-ci-robot]

@amitkrout: The label(s) kind/enhancement cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga

In response to this:

/kind bug
/kind enhancement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[amitkrout]

• Storage command - Removes app,project and component flag from storage commands #2238

• Url command - remove --app, --component and --project from odo url #2247

More to come

[amitkrout]

ping @kadel @dgolovin

[girishramnani]

Intrested in doing the url one, if someone hasn't started
cc @mik-dass

[mik-dass]

Intrested in doing the url one, if someone hasn't started
cc @mik-dass

@girishramnani There is already a PR open for it #2247

[girishramnani]

I opened it 😄

[mik-dass]

I opened it smile

Yeah I know, thanks for that :D

[kadel]

We need a list of the commands from which the flags should be removed!

[kadel]

• we need to check with vscode adapter that they are not using it

did someone check this?

[girishramnani]

The only commands that should have the above flags is link, unlink and service stuff
A PR opened earlier removes then from storage and
One more is still open which removes them from url.

No other places have them incorrectly placed.
cc @kadel

[girishramnani]

ping @dgolovin

• we need to check with vscode adapter that they are not using it

[kadel]

There is odo.ts file inside the vscode plug source that contains all the odo commands execute by plugin in place.

You can look there.

I just did a quick check. url commands look clean. But there is a odo storage command using all 3 of them https://github.com/redhat-developer/vscode-openshift-tools/blob/8388b83e750c686b773fed91e6275da425675576/src/odo.ts#L139

[girishramnani]

and the odo storage PR #2238 already got merged in, which means if we do a release the vscode plugin would break? @kadel

[kadel]

and the odo storage PR #2238 already got merged in, which means if we do a release the vscode plugin would break? @kadel

yes!

[girishramnani]

then we should probably tell them 😅

[mohitsuman]

We will update the odo storage command to use --context. This goes for beta-7 release, right ?

[girishramnani]

yes

[girishramnani]

@amitkrout I went through the code and it seems these are the only places from where we need to remove --project, --app and --component commands.
Closing this issue as we have already

• removed the flags from the url and storage
• notified the adapters team about the removal of flag - they opened an issue to handle the change on their end remove --project, --app, --component flags from storage command vscode-openshift-tools#1226
• checked and confirmed if the flags are to be removed from somewhere else or not