Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link tests are never executed!! #2262

Closed
kadel opened this issue Oct 9, 2019 · 4 comments · Fixed by #2263
Closed

Link tests are never executed!! #2262

kadel opened this issue Oct 9, 2019 · 4 comments · Fixed by #2263
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering priority/Critical We need to stop doing everything and fix this ASAP. It is making the project unusable.

Comments

@kadel
Copy link
Member

kadel commented Oct 9, 2019

Form travis-ci logs:

$ make test-cmd-link-unlink
ginkgo -v -randomizeAllSpecs -slowSpecThreshold=120 -timeout 7200s -nodes=2 -focus="odo link and unlink command tests" tests/integration/
Running Suite: Integration Suite
================================
Random Seed: 1570456653 - Will randomize all specs
Will run 106 specs
Running in parallel across 2 nodes
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
Ran 0 of 106 Specs in 0.064 seconds
SUCCESS! -- 0 Passed | 0 Failed | 0 Pending | 106 Skipped

It looks like that all tests are skipped!

/area testing
/priority critical
@openshift-ci-robot openshift-ci-robot added area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering priority/Critical We need to stop doing everything and fix this ASAP. It is making the project unusable. labels Oct 9, 2019
@kadel
Copy link
Member Author

kadel commented Oct 9, 2019

There is far more than this. Like Service tests

ginkgo -v -randomizeAllSpecs -slowSpecThreshold=120 -timeout 7200s -nodes=2 -focus="odo service command tests" tests/integration/
Running Suite: Integration Suite
================================
Random Seed: 1570456638 - Will randomize all specs
Will run 106 specs
Running in parallel across 2 nodes
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
Ran 0 of 106 Specs in 0.056 seconds
SUCCESS! -- 0 Passed | 0 Failed | 0 Pending | 106 Skipped

@amitkrout
Copy link
Contributor

I can see it from the Makefile, even service command is also excluded. Will send the pr ASAP.

In the mean time let me check from where it was misplaced. AFAIK in the beginning it was there.

@kadel
Copy link
Member Author

kadel commented Oct 9, 2019

problem is in Makefile
https://github.com/openshift/odo/blob/9318bc163fd0f5c80b32e8c32c43c539c0985a24/Makefile#L138

it should be tests/integration/servicecatalog

which is a little bit odd as linking is not a service catalog, but that is a different story

@amitkrout amitkrout mentioned this issue Oct 9, 2019
Merged
@amitkrout
Copy link
Contributor

I can see it from the Makefile, even service command is also excluded. Will send the pr ASAP.

In the mean time let me check from where it was misplaced. AFAIK in the beginning it was there.

@kadel After beta5 release it was misplaced.

@amitkrout amitkrout mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering priority/Critical We need to stop doing everything and fix this ASAP. It is making the project unusable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include service and link command tests amitkrout/odo
3 participants
@kadel @amitkrout @openshift-ci-robot