Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests required for pkg/kclient/ingress.go & secrets.go #2657

Closed
yangcao77 opened this issue Feb 28, 2020 · 1 comment · Fixed by #2762
Closed

Unit tests required for pkg/kclient/ingress.go & secrets.go #2657

yangcao77 opened this issue Feb 28, 2020 · 1 comment · Fixed by #2762
Assignees
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering

Comments

@yangcao77
Copy link
Contributor

yangcao77 commented Feb 28, 2020

While creating the base function for ingress support in kclient, (as part of #2636), the unit test for pkg/kclient/ingress.go & secrets.go is missing in that PR.

The functions might be changed, and more functions might be added when implementing the feature of ingress support for odo url create/list/delete when devfile is provided. (#2592)

Creating this issue to track the absence of unit tests for ingress.go and secrets.go under kclient pkg.

/area testing

@openshift-ci-robot openshift-ci-robot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Feb 28, 2020
@yangcao77
Copy link
Contributor Author

/assign

@yangcao77 yangcao77 changed the title Unit tests required for pkg/kclient/ingress.go Unit tests required for pkg/kclient/ingress.go & secrets.go Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants