Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filepath.Join("/tmp", randomFileName) does not support on windows #3246

Closed
prietyc123 opened this issue May 26, 2020 · 2 comments · Fixed by #3252
Closed

filepath.Join("/tmp", randomFileName) does not support on windows #3246

prietyc123 opened this issue May 26, 2020 · 2 comments · Fixed by #3252
Labels
good first issue Denotes an issue ready for a new contributor. Maintainers will help mentor new contributors. kind/bug Categorizes issue or PR as related to a bug.

Comments

@prietyc123
Copy link
Contributor

/kind bug

What versions of software are you using?

Operating System:
Windows

Output of odo version:
master

How did you run odo exactly?

Running filepath.Join("/tmp", randomFileName) on windows.

Actual behavior

/tmp/randomFileName throws error as /tmp won't be identified on windows.

Expected behavior

Defining /tmp in some context should work

Any logs, error output, etc?
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 26, 2020
@prietyc123 prietyc123 mentioned this issue May 26, 2020
Merged
@johnmcollier
Copy link
Member

Can we safely use os.TempDir() in place of that?

@dharmit dharmit added the good first issue Denotes an issue ready for a new contributor. Maintainers will help mentor new contributors. label May 27, 2020
@amitkrout
Copy link
Contributor

Can we safely use os.TempDir() in place of that?

yes, we can do that

@prietyc123 prietyc123 mentioned this issue May 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor. Maintainers will help mentor new contributors. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix windows incompatibility with /tmp prietyc123/odo
5 participants
@dharmit @johnmcollier @amitkrout @openshift-ci-robot @prietyc123