Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"odo service create --from-file" for invalid metadata does not match the output on windows #3390

Closed
prietyc123 opened this issue Jun 19, 2020 · 7 comments
Labels
area/Windows Issues or PRs specific to Windows kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects

Comments

@prietyc123
Copy link
Contributor

/kind bug

What versions of software are you using?

Operating System:
Win10

Output of odo version:
master

How did you run odo exactly?

Ranning make test-operator-hub on windows powershell. Tried to run tests multiple times.

Actual behavior

> make test-operator-hub
ginkgo  -randomizeAllSpecs -slowSpecThreshold=120 -timeout 7200s -nodes=1 -focus="odo service command tests" tests/integration/operatorhub/
Running Suite: Operatorhub Suite
================================
Random Seed: 1592546601 - Will randomize all specs
Will run 7 of 7 specs

+Could not write yaml spec to file \tmp\smcrcr.yaml because of the error open \tmp\smcrcr.yaml: The system cannot find the path specified.Running odo.exe with args [odo preference set Experimental true]
[odo] I0619 06:03:44.785273   10984 preference.go:188] The path for preference file is C:\Users\Admin\.odo\preference.yaml
[odo] ? Experimental is already set. Do you want to override it in the config (y/N) I0619 06:03:44.834277   10984 common.go:1
7] Encountered an error processing prompt: Incorrect function.
[odo] Aborted by the user
[odo] I0619 06:03:44.834277   10984 odo.go:72] Could not get the latest release information in time. Never mind, exiting gracefully :)
Creating a new project: pewqlvqofc
Running odo.exe with args [odo project create pewqlvqofc -w -v4]
[odo]  -  Waiting for project to come up  ...
[odo] I0619 06:03:46.709064    9092 occlient.go:543] Status of creation of project pewqlvqofc is Active
[odo] I0619 06:03:46.754953    9092 occlient.go:548] Project pewqlvqofc now exists
[odo] I0619 06:03:46.787973    9092 occlient.go:583] Status of creation of service account &ServiceAccount{ObjectMeta:{default  pewqlvqofc /api/v1/namespaces/pewqlvqofc/serviceaccounts/default b668491d-b08b-4dd8-b5a3-7cd51cccf9b6 52565 0 2020-06-19 06:03:46 +0000 GMT <nil> <nil> map[] map[] [] []  []},Secrets:[]ObjectReference{ObjectReference{Kind:,Namespace:,Name:default-token-qkzbk,UID:,APIVersion:,ResourceVersion:,FieldPath:,},ObjectReference{Kind:,Namespace:,Name:default-dockercfg-h2jlk,UID:,APIVersion:,ResourceVersion:,FieldPath:,},},ImagePullSecrets:[]LocalObjectReference{LocalObjectReference{Name:default-dockercfg-h2jlk,},},AutomountServiceAccountToken:nil,} is ready
 V  Waiting for project to come up [2s]
[odo]  V  Project 'pewqlvqofc' is ready for use
[odo]  V  New project created and now using project: pewqlvqofc
[odo] I0619 06:03:46.811465    9092 odo.go:72] Could not get the latest release information in time. Never mind, exiting gracefully :)
Running odo.exe with args [odo project set pewqlvqofc]
[odo] Already on project : pewqlvqofc
[odo] I0619 06:03:47.128006   10336 odo.go:72] Could not get the latest release information in time. Never mind, exiting gracefully :)
Running oc.exe with args [oc get csv]
[oc] NAME                              DISPLAY   VERSION             REPLACES   PHASE
[oc] etcdoperator.v0.9.4-clusterwide   etcd      0.9.4-clusterwide
[oc] mongodb-enterprise.v1.5.3         MongoDB   1.5.3
Running oc.exe with args [oc get csv]
[oc] NAME                              DISPLAY   VERSION             REPLACES   PHASE
[oc] etcdoperator.v0.9.4-clusterwide   etcd      0.9.4-clusterwide
[oc] mongodb-enterprise.v1.5.3         MongoDB   1.5.3
Running odo.exe with args [odo service create --from-file \tmp\smcrcr.yaml]
[odo] I0619 06:03:50.220542   11244 preference.go:188] The path for preference file is C:\Users\Admin\.odo\preference.yaml
[odo] I0619 06:03:50.263372   11244 preference.go:188] The path for preference file is C:\Users\Admin\.odo\preference.yaml
[odo]  X  CreateFile \tmp\smcrcr.yaml: The system cannot find the path specified.
Deleting project: pewqlvqofc
Running odo.exe with args [odo project delete pewqlvqofc -f]
[odo] I0619 06:03:50.626824    2580 application.go:49] Unable to list Service Catalog instances: unable to list ServiceInstances: the server could not find 
the requested resource (get serviceinstances.servicecatalog.k8s.io)
[odo]  V  Deleted project : pewqlvqofc
[odo]  !  Warning! Projects are deleted from the cluster asynchronously. Odo does its best to delete the project. Due to multi-tenant clusters, the project 
may still exist on a different node.
[odo] I0619 06:03:50.722536    2580 odo.go:72] Could not get the latest release information in time. Never mind, exiting gracefully :)

------------------------------
+ Failure [6.083 seconds]
odo service command tests for OperatorHub
C:/Users/Admin/go/src/github.com/openshift/odo/tests/integration/operatorhub/cmd_service_test.go:17
  When using from-file option
  C:/Users/Admin/go/src/github.com/openshift/odo/tests/integration/operatorhub/cmd_service_test.go:158
    should fail to create service if metadata doesn't exist or is invalid [It]
    C:/Users/Admin/go/src/github.com/openshift/odo/tests/integration/operatorhub/cmd_service_test.go:168

    Expected
        <string>: I0619 06:03:50.220542   11244 preference.go:188] The path for preference file is C:\Users\Admin\.odo\preference.yaml
        I0619 06:03:50.263372   11244 preference.go:188] The path for preference file is C:\Users\Admin\.odo\preference.yaml
         X  CreateFile \tmp\smcrcr.yaml: The system cannot find the path specified.

    to contain substring
        <string>: Couldn't find "metadata" in the yaml

    C:/Users/Admin/go/src/github.com/openshift/odo/tests/integration/operatorhub/cmd_service_test.go:195
------------------------------
+++++

Summarizing 1 Failure:

[Fail] odo service command tests for OperatorHub When using from-file option [It] should fail to create service if metadata doesn't exist or is invalid     
C:/Users/Admin/go/src/github.com/openshift/odo/tests/integration/operatorhub/cmd_service_test.go:195

Ran 7 of 7 Specs in 113.684 seconds
FAIL! -- 6 Passed | 1 Failed | 0 Pending | 0 Skipped
--- FAIL: TestOperatorhub (113.83s)
FAIL

Ginkgo ran 1 suite in 2m0.5020615s
Test Suite Failed
make: *** [test-operator-hub] Error 1

Expected behavior

odo service create --from-file <filename> should have same output for all the platform.

Any logs, error output, etc?

Ran the test manually. Logs are in actual behaviour. 👀

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 19, 2020
@prietyc123
Copy link
Contributor Author

ping @dharmit

@prietyc123 prietyc123 added the area/Windows Issues or PRs specific to Windows label Jul 10, 2020
@prietyc123 prietyc123 added this to For consideration in Sprint 191 via automation Oct 7, 2020
@prietyc123 prietyc123 added this to For consideration in Sprint 192 via automation Oct 26, 2020
@prietyc123 prietyc123 removed this from For consideration in Sprint 191 Oct 26, 2020
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 26, 2020
@dharmit dharmit removed this from For consideration in Sprint 192 Nov 12, 2020
@prietyc123 prietyc123 assigned anandrkskd and unassigned anandrkskd Nov 16, 2020
@prietyc123 prietyc123 added this to For Consideration in Sprint 193 via automation Nov 16, 2020
@dharmit
Copy link
Member

dharmit commented Nov 19, 2020

This will become irrelevant once #4159 & then #4160 are addressed. We will get rid of --from-file when the CRD gets stored in devfile. So the user can modify the metadata or anything in the CRD right in the devfile instead of storing it in a separate file and using that to spin up the service.

@dharmit dharmit removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 4, 2020
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 4, 2021
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 3, 2021
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link
Collaborator

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sprint 193 automation moved this from For Consideration to Done May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Windows Issues or PRs specific to Windows kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
No open projects
Development

No branches or pull requests

5 participants