Move "GetComponentContext" to a util package

[dharmit]

• In pkg/odo/cli/url, we are calling this method which is in pkg/odo/cli/component.
• URLCreateOptions and PushOptions are used interchangeably (as I can see, GetComponentContext is in the method set of PushOptions struct).
• Also, this function gets the value which can be used in other CLI packages as well.

It seems like this function belongs to some kind of util package, or other top level file for some component instead of being in pkg/odo/cli/component/push.go.

Besides that, should it be removed from the method set of PushOptions and put somewhere else? Some kind of common options that are common among various different options viz. PushOptions, URLCreateOptions, ComponentOptions, etc.

Originally posted by @dharmit in #4311 (comment)

/kind discussion
/kind code-refactoring
/good-first-issue

[openshift-ci-robot]

@dharmit:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

• In pkg/odo/cli/url, we are calling this method which is in pkg/odo/cli/component.
• URLCreateOptions and PushOptions are used interchangeably (as I can see, GetComponentContext is in the method set of PushOptions struct).
• Also, this function gets the value which can be used in other CLI packages as well.

It seems like this function belongs to some kind of util package, or other top level file for some component instead of being in pkg/odo/cli/component/push.go.

Besides that, should it be removed from the method set of PushOptions and put somewhere else? Some kind of common options that are common among various different options viz. PushOptions, URLCreateOptions, ComponentOptions, etc.

Originally posted by @dharmit in #4311 (comment)

/kind discussion
/kind code-refactoring
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[niconosenzo]

@dharmit If this is ok for you, I may have a look and discuss some ideas before submitting any change.

[dharmit]

@niconosenzo absolutely! Discussing before coding is always welcome! If you'd like to work on this, feel free to assign it to yourself.

[niconosenzo]

/assign

[mik-dass]

In pkg/odo/cli/url, we are calling this method which is in pkg/odo/cli/component.
URLCreateOptions and PushOptions are used interchangeably (as I can see, GetComponentContext is in the method set of PushOptions struct).

We are using the GetComponentContext() in other packages like cli for URL etc to trigger the push logic for the now flag in other packages.

https://github.com/openshift/odo/blob/e7664393988c11683588232b50e944484fbea999/pkg/odo/cli/url/create.go#L189

Besides that, should it be removed from the method set of PushOptions and put somewhere else?

The fix would be to design a way so that we can trigger Push() from the component package without requiring the dependency of the component CLI code https://github.com/openshift/odo/blob/e7664393988c11683588232b50e944484fbea999/pkg/odo/cli/url/create.go#L10 but that might need a lot of refactoring.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.