start using SBO again

[kadel]

new SBO version hard codes binding definitions for some of the operators. This might make using SBO with odo much easier

• investigate if we can leverage this to fix odo link flow broken on latest SBO 0.10. #5084
• Investigate which Operators' annotations have been hard-coded by SBO and add tests for these in odo
  • Doesn't have to be all operators in a single sprint.
  • MVP would be to manually test it, but automate at least one in the first sprint

/triage needs-information

[kadel]

/assign
/kind service-binding

[openshift-ci]

@kadel: The label(s) kind/service-binding cannot be applied, because the repository doesn't have them.

In response to this:

/assign
/kind service-binding

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kadel]

/priority high
due to #5207

[dharmit]

For sprint 211, let's figure out how to move back to using SBO again. The code to be uncommented is at:

odo/pkg/kclient/operators.go

Lines 30 to 35 in 5f79c54

	// IsServiceBindingSupported checks if resource of type service binding request present on the cluster
	func (c *Client) IsServiceBindingSupported() (bool, error) {
	// Detection of SBO has been removed from issue https://github.com/redhat-developer/odo/issues/5084
	return false, nil
	// return c.IsResourceSupported("binding.operators.coreos.com", "v1alpha1", "servicebindings")
	}

Uncomment and test things.

[feloy]

The service binding operator v1.0 is setting default annotations to the Redis operator CRD, which are using non mandatory fields, and that causes problems with odo integration tests not using these fields (specifically .spec.redisSecret on redis.redis.opstreelabs.in/v1beta1).

redhat-developer/service-binding-operator#1088

[valaparthvi]

We are using SBO for tests and library when it's not available. I am going to close this issue. If anyone thinks it's still an issue, feel free to reopen it.