add support for all command types to events

[kadel]

currently the exec command is not supported in events

helm-install-postgresql should either map to an apply command or a composite command with apply commands

[kadel]

There was a discussion with a user who would require this to use odo and devfile in their environment.

The discussed use-case is using #6549 they would mount secrets like SSL certificates into the container, and then using postStart they would execute command to import SSL certs

[valaparthvi]

@kadel would you be able to provide a sample Devfile for this case?

[valaparthvi]

Note: We need to figure this out for podman as well.

[valaparthvi]

preStart, postStop events can only be an apply command or a composition of apply command.
postStart, and preStop can only be an exec command or composite exec command.

The above are Devfile limitations.

odo/vendor/github.com/devfile/api/v2/pkg/validation/events.go

Lines 48 to 52 in f9baeec

	// isEventValid checks if events belonging to a specific event type are valid ie;
	// 1. event should map to a valid devfile command
	// 2. preStart and postStop events should either map to an apply command or a composite command with apply commands
	// 3. postStart and preStop events should either map to an exec command or a composite command with exec commands
	func isEventValid(eventNames []string, eventType string, commandMap map[string]v1alpha2.Command) error {

Currently, odo only supports postStart, and preStop.

[valaparthvi]

PreStart events:
odo does not support preStart yet.
Implement exec command as a Job. We wait for the job to complete, and if the job fails, the command fails. Every command will run in its own individual job. the command would be short running. How long should we wait? Print tip to run odo logs after a minute?

Implement apply command, build an image/create k8s/oc resources. For container components, if it is supported, simply create a Deployment. The command should be long running? We do not wait for the command to finish, move on once the deployment has been created.

Case of apply on container component with mountSources=true. How do we sync the sources?

Composite apply command: (container component) run every apply command separately.

Support composite exec and apply command.

First thing:

• write a doc describing what we want to do for each step/type of event

[feloy]

AutoBuild and DeployByDefault on components can be used to work as Apply *Start events

[feloy]

Moving this issue out of the Epic #5834

[github-actions]

A friendly reminder that this issue had no activity for 90 days. Stale issues will be closed after an additional 30 days of inactivity.

[github-actions]

This issue was closed because it has been inactive for 30 days since being marked as stale.