Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support variable substitution with odo build-images #6274

Closed
Tracked by #5834
rm3l opened this issue Oct 31, 2022 · 0 comments · Fixed by #6776
Closed
Tracked by #5834

Support variable substitution with odo build-images #6274

rm3l opened this issue Oct 31, 2022 · 0 comments · Fixed by #6776
Assignees
Labels
kind/user-story An issue of user-story kind priority/Medium Nice to have issue. Getting it done before priority changes would be great. sprint demo Indicates an issue for which a demo should be recorded and presented at the end of the sprint.
Milestone

Comments

@rm3l
Copy link
Member

rm3l commented Oct 31, 2022

/kind feature

Which functionality do you think we should add?

I was trying to leverage odo to build and push images defined in a Devfile to my local registry, but this is currently not implemented.

$ odo build-images --var CONTAINER_IMAGE=localhost:5000/rm3l/mac-oui:`git rev-parse --short HEAD`
 ✗  --var-file and --var flags are not supported for this command

Why is this needed?

Just like odo deploy supports variable substitution when applying image components, odo build-images should be able to do the same thing, I think.

Variable substitution is helpful to pass values from the CLI without modifying the Devfile.
It should be possible to do the same thing with odo build-images to build images and push them to different registries for example.

This extends #5489.

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Oct 31, 2022
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Oct 31, 2022
@rm3l rm3l added kind/user-story An issue of user-story kind and removed kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. labels Nov 17, 2022
@rm3l rm3l added the priority/Medium Nice to have issue. Getting it done before priority changes would be great. label Dec 12, 2022
@valaparthvi valaparthvi added the sprint demo Indicates an issue for which a demo should be recorded and presented at the end of the sprint. label Apr 18, 2023
@rm3l rm3l added this to the v3.10.0 🚀 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/user-story An issue of user-story kind priority/Medium Nice to have issue. Getting it done before priority changes would be great. sprint demo Indicates an issue for which a demo should be recorded and presented at the end of the sprint.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants