Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add app.openshift.io/vcs-uri annotation on Podman resources #6493

Closed
Tracked by #6578
rm3l opened this issue Jan 16, 2023 · 2 comments · Fixed by #6746
Closed
Tracked by #6578

Add app.openshift.io/vcs-uri annotation on Podman resources #6493

rm3l opened this issue Jan 16, 2023 · 2 comments · Fixed by #6746
Assignees
@feloy
Labels
area/odo-on-podman Issues or PRs related to running odo against Podman kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation
Milestone
v3.10.0 🚀

Comments

@rm3l
Copy link
Member

rm3l commented Jan 16, 2023 •
edited
Loading

/kind feature
/area odo-on-podman

Which functionality do you think we should add?

Came across this while pair-programming on #6447

Related test: should create vcs-uri annotation for the deployment when running odo dev

Why is this needed?

To be consistent with the way we manage labels and annotations on both Kubernetes and Podman (#6317)
@rm3l rm3l added kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation area/odo-on-podman Issues or PRs related to running odo against Podman labels Jan 16, 2023
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Jan 16, 2023
@rm3l rm3l changed the title Add app.openshift.io/vcs-uri annotation on resources created by Podman Add app.openshift.io/vcs-uri annotation on Podman resources Jan 16, 2023
@rm3l rm3l mentioned this issue Jan 18, 2023
Closed
25 tasks
@valaparthvi
Copy link
Member

valaparthvi commented Feb 2, 2023 •
edited
Loading

vcs-uri annotation is helpful in determining the source code of the container.
Ref: https://github.com/redhat-developer/app-labels/blob/master/labels-annotation-for-openshift.adoc#annotations

@valaparthvi
Copy link
Member

The value for this annotation should be same as is implemented for cluster.

@kadel kadel mentioned this issue Feb 8, 2023
Closed
8 tasks
@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Mar 23, 2023
@feloy feloy assigned feloy and unassigned feloy Apr 18, 2023
@feloy feloy mentioned this issue Apr 18, 2023
Merged
3 tasks
@feloy feloy self-assigned this Apr 18, 2023
@rm3l rm3l added this to the v3.10.0 🚀 milestone Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feloy feloy

Labels
area/odo-on-podman Issues or PRs related to running odo against Podman kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation
Projects
odo Project
Archived in project
Milestone
v3.10.0 🚀
Development

Successfully merging a pull request may close this issue.

Set vcs-uri annotation on podman feloy/odo
3 participants
@rm3l @feloy @valaparthvi