Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image name as selector: implementation in odo #6677

Closed
7 of 8 tasks
Tracked by #6565
rm3l opened this issue Mar 23, 2023 · 2 comments · Fixed by #6768
Closed
7 of 8 tasks
Tracked by #6565

Image name as selector: implementation in odo #6677

rm3l opened this issue Mar 23, 2023 · 2 comments · Fixed by #6768
Assignees
@rm3l
Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). sprint demo Indicates an issue for which a demo should be recorded and presented at the end of the sprint.
Milestone
v3.11.0 🚀

Comments

@rm3l
Copy link
Member

rm3l commented Mar 23, 2023 •
edited

/kind user-story

User Story

As an odo user, I want odo to push images from Image Components to a given registry and use that for all matching Kubernetes/OpenShift components manifests, without having to hardcode that information into my Devfile, so that I can keep my devfile portable.

See #6565 and devfile/api#985 (comment) for more context.

Acceptance Criteria

  • odo should have a preference that allows users to globally configure image registry
  • odo dev and odo deploy commands should have a flag that allows users to specify image registry, this overrides the global configuration (preference)
  • odo should pass the user-defined image registry to the Devfile parser so that it can return the resolved image names
  • odo dev, odo deploy and odo build-images should push the images to the specified registry
  • Matching images in other Kubernetes/OpenShift components should use the image built and pushed to the specified registry
  • Non-matching images should be pushed where they are defined
  • It should also behave the same way on both cluster and Podman
  • Document this behavior

Links
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Mar 23, 2023
@rm3l rm3l added the kind/task Issue is actionable task label Mar 23, 2023
@rm3l
Copy link
Member Author

rm3l commented Mar 23, 2023

/remove-kind task
/kind user-story
/area devfile-spec
/priority High

Converting this into a user story and setting the same priority as its parent user story: #6565

@openshift-ci openshift-ci bot added kind/user-story An issue of user-story kind area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). and removed kind/task Issue is actionable task labels Mar 23, 2023
@rm3l rm3l removed the needs-triage Indicates an issue or PR lacks a `triage/*` and requires one. label Mar 23, 2023
@rm3l rm3l mentioned this issue Mar 23, 2023
Closed
4 tasks
@valaparthvi
Copy link
Member

valaparthvi commented Apr 5, 2023 •
edited

/status blocked
#6676

@rm3l rm3l added the status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) label Apr 14, 2023
@rm3l rm3l self-assigned this Apr 20, 2023
This was referenced Apr 24, 2023
Merged
Closed
@rm3l rm3l added this to the v3.10.0 🚀 milestone Apr 26, 2023
@rm3l rm3l added the sprint demo Indicates an issue for which a demo should be recorded and presented at the end of the sprint. label May 2, 2023
@valaparthvi valaparthvi modified the milestones: v3.10.0 🚀, v3.11.0 🚀 May 2, 2023
@rm3l rm3l removed the status/blocked Denotes an issue or PR that is blocked on something (e.g., issue/PR in different repo) label May 16, 2023
@rm3l rm3l mentioned this issue Jul 5, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rm3l rm3l

Labels
area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/user-story An issue of user-story kind priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). sprint demo Indicates an issue for which a demo should be recorded and presented at the end of the sprint.
Projects
odo Project
Archived in project
Milestone
v3.11.0 🚀
Development

Successfully merging a pull request may close this issue.

Allow using imageName as a selector rm3l/odo
2 participants
@rm3l @valaparthvi