Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate application.properties: required properties #21

Closed
angelozerr opened this issue Aug 13, 2019 · 7 comments
Closed

Validate application.properties: required properties #21

angelozerr opened this issue Aug 13, 2019 · 7 comments
Assignees
Labels
enhancement New feature or request properties Features supported in application.properties quarkus-ls Quarkus Language Server Issue validation
Milestone

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Aug 13, 2019

Validate application.properties:

@angelozerr angelozerr added enhancement New feature or request quarkus-ls Quarkus Language Server Issue properties Features supported in application.properties validation labels Aug 13, 2019
@xorye
Copy link

xorye commented Sep 24, 2019

@angelozerr is this issue only for @ConfigProperty?

If this issue is also for @configroot, @configitem etc, I will investigate more about the meaning of "required" for @configroot, @configitem etc.

@angelozerr
Copy link
Contributor Author

The original issue was about required for any annotation but we can split this issue in two issues if you wish. Please rename this issue (by adding for ConfigProperty) and create a new issue for ConfigRoot.

But it means ExtendedConfigDescriptionBuildItem should return the annotation origin of the Quarkus property computing,no?

@xorye
Copy link

xorye commented Sep 24, 2019

But it means ExtendedConfigDescriptionBuildItem should return the annotation origin of the Quarkus property computing,no?

Can this be inferred from location or source?

@angelozerr
Copy link
Contributor Author

No, you can have ConfigRoot and ConfigProperty from JARs and source both. If you wish I can manage that in an another PR. For the moment you could check if property starts with quarkus (=ConfigRoot).

@xorye
Copy link

xorye commented Sep 24, 2019

Maybe it might be better to depend on required, since it would take care of required for any annotation. I will investigate more

@angelozerr
Copy link
Contributor Author

Maybe it might be better to depend on required, since it would take care of required for any annotation. I will investigate more

Yes it was my idea. You need to fill th erequired info from the JDTQuarkusManager. If you need help, please tell me

@angelozerr
Copy link
Contributor Author

Fixed with #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request properties Features supported in application.properties quarkus-ls Quarkus Language Server Issue validation
Projects
None yet
Development

No branches or pull requests

2 participants