Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate application.properties: type value #33

Closed
angelozerr opened this issue Aug 14, 2019 · 2 comments · Fixed by #94
Closed

Validate application.properties: type value #33

angelozerr opened this issue Aug 14, 2019 · 2 comments · Fixed by #94
Assignees
@xorye
Labels
enhancement New feature or request quarkus-ls Quarkus Language Server Issue validation
Milestone
v0.0.2

Comments

@angelozerr
Copy link
Contributor

According the type value (ex : int, boolean, other?), validation should be done:

Ex :

  • with quarkus.datasource.enable-metrics which is a boolean

quarkus.datasource.enable-metrics = XXXX

XXXX should be marked as error

  • with quarkus.datasource.max-size which is an int

quarkus.datasource.max-size = XXXX

XXXX should be marked as error
@angelozerr angelozerr added enhancement New feature or request quarkus-ls Quarkus Language Server Issue validation labels Aug 14, 2019
@fbricon
Copy link
Collaborator

fbricon commented Aug 14, 2019

It might not work, if the values are injected at build time, by Maven/Gradle, eg: ${value.from.pom}

@fbricon
Copy link
Collaborator

fbricon commented Sep 5, 2019 •
edited

Keep in mind some properties can be injected at build time ${something}, so it should not be validated

@xorye xorye mentioned this issue Sep 18, 2019
Merged
@angelozerr angelozerr added this to the v0.2.0 milestone Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xorye xorye

Labels
enhancement New feature or request quarkus-ls Quarkus Language Server Issue validation
Projects
None yet
Milestone
v0.0.2
Development

Successfully merging a pull request may close this issue.

Validate application.properties value type
3 participants
@fbricon @angelozerr @xorye