Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractQuteTemplateLinkCollector wrongly identifies Template fields #683

Closed
jeffmaury opened this issue Jul 28, 2022 · 1 comment · Fixed by #719
Closed

AbstractQuteTemplateLinkCollector wrongly identifies Template fields #683

jeffmaury opened this issue Jul 28, 2022 · 1 comment · Fixed by #719
Assignees
Labels
bug Something isn't working good first issue Good for newcomers qute validation
Milestone

Comments

@jeffmaury
Copy link
Member

Only the last part of the field class name is used, there is a constant in QuteConstants for the whole class name

@rgrunber rgrunber added bug Something isn't working good first issue Good for newcomers labels Aug 3, 2022
@rgrunber
Copy link
Member

rgrunber commented Aug 3, 2022

Yup! This looks like a bug. We need to check that the type matches io.quarkus.qute.Template, not just Template.

Would be good to confirm that if one defines their own type, com.example.Template, and annotates it with @Location, that it leads to bad behaviour.

@datho7561 datho7561 added this to the 0.13.0 milestone Aug 25, 2022
@rgrunber rgrunber changed the title AbstractQuteTemplateLinkCollector wongly identifies Template fields AbstractQuteTemplateLinkCollector wrongly identifies Template fields Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers qute validation
Projects
None yet
4 participants