Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert annotation handling mechanism to not use the original config map or secret resource name location #485

Closed
isutton opened this issue May 25, 2020 · 1 comment · Fixed by #522
Assignees
Labels
kind/bug Something isn't working v0.3.0

Comments

@isutton
Copy link
Contributor

isutton commented May 25, 2020

After #407 an undocumented behavior regarding annotations meant to extract config map and secret values has been unwillingly changed and needs to be reverted.

The annotations handling mechanism after #407 extracts the whole contents of the config map or secret to the same path where the config map or secret name has been stored (resulting in, for example, .status.secretName.password if .data.password is present in the associated resource) to workaround situations where two services might have a password field within different paths and might get shadowed, whereas before #407 it used to extract the contents to the root of the resulting object (for example, .password), imposing no issue whatsoever because there were only one service being declared in the binding.

For reference, see #475 (comment).

@sbose78 sbose78 added the kind/bug Something isn't working label May 26, 2020
@sbose78 sbose78 added the v0.3.0 label Jun 23, 2020
@sbose78
Copy link
Member

sbose78 commented Jun 23, 2020

@isutton would you want to pick this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working v0.3.0
Projects
None yet
2 participants