Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression/Breaking changes in 0.7.0 #945

Closed
wtrocki opened this issue Apr 12, 2021 · 3 comments · Fixed by #949
Closed

Regression/Breaking changes in 0.7.0 #945

wtrocki opened this issue Apr 12, 2021 · 3 comments · Fixed by #949
Labels
kind/bug Something isn't working

Comments

@wtrocki
Copy link

wtrocki commented Apr 12, 2021

Different

It looks like sbo binds files by default in openshift console.

0.6.0 release

sh-4.2$ ls /bindings/nodejs-sample-d-ajay-test-akc/
clientsecret user password type clientid

After 0.7.0

 sh-4.2$ ls /bindings/nodejs-sample-d-ajay-test-akc/
KAFKACONNECTION_BOOTSTRAPSERVERS  KAFKACONNECTION_CLIENTSECRET  KAFKACONNECTION_PROVIDER       KAFKACONNECTION_SECURITYPROTOCOL  KAFKACONNECTION_USER
KAFKACONNECTION_CLIENTID          KAFKACONNECTION_PASSWORD      KAFKACONNECTION_SASLMECHANISM  KAFKACONNECTION_TYPE

0.7.0 is not aligned with how spec does it.

@wtrocki wtrocki added the kind/bug Something isn't working label Apr 12, 2021
@pedjak
Copy link
Contributor

pedjak commented Apr 13, 2021

hm, our tests

Scenario: Binding is injected as files at the location of SERVICE_BINDING_ROOT env var
verify that the behavior is according to the spec. Can you share you service binding you try to apply?

@wtrocki
Copy link
Author

wtrocki commented Apr 13, 2021

Not sure if service binding is the issue as it is being created by OpenShift Topology as in our summit guides.
Maybe problem is in the spec:

https://github.com/redhat-developer/app-services-operator/blob/main/olm/olm-template/manifests/rhoas-operator.kafkaconnections.crd.yaml#L7-L21

@pedjak
Copy link
Contributor

pedjak commented Apr 13, 2021

I can confirm the issue. #949 is going to fix it. Until then, setting spec.namingStrategy: none can work around the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
2 participants