Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom color for arguments used in method body #1277

Closed
0y0y opened this issue Feb 17, 2020 · 4 comments
Closed

Custom color for arguments used in method body #1277

0y0y opened this issue Feb 17, 2020 · 4 comments

Comments

@0y0y
Copy link

0y0y commented Feb 17, 2020

It's not possible to identify arguments used in the method body. So we can't use the same color for better code readability.

Environment
  • Operating System: windows10
  • JDK version: Oracle 10.0.2
  • Visual Studio Code version: 1.42.1
  • Java extension version: 0.55.1
Current Result

image

image

Expected Result

Textmate scope for arguments in method body

@fbricon
Copy link
Collaborator

fbricon commented Feb 17, 2020

The textmate grammar is defined in vscode itself, but the source of the grammar is actually atom, so the problem should be reported there: https://github.com/atom/language-java/issues

@0y0y
Copy link
Author

0y0y commented Feb 17, 2020

Ok thanks.

atom/language-java#222

@akaroml
Copy link
Contributor

akaroml commented Feb 18, 2020

@Vigilans did you happen to fix this at Atom side? If so, please help integrate that to vscode repo.

@fbricon
Copy link
Collaborator

fbricon commented Apr 27, 2020

This is partially fixed with the new semantic highlighting support in vscode-java 0.61.0. Requires "java.semanticHighlighting.enabled": true in settings.json. Without semantic highlighting, the Textmate grammar is still broken.

@fbricon fbricon closed this as completed Apr 27, 2020
@fbricon fbricon added the bug label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants