Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corner case in parsing major version of JDK #1331

Closed
Eskibear opened this issue Mar 16, 2020 · 2 comments
Closed

Corner case in parsing major version of JDK #1331

Eskibear opened this issue Mar 16, 2020 · 2 comments

Comments

@Eskibear
Copy link
Contributor

The logic is to parse the string after "version", but for someone with AdoptOpenJDK 11.0.x, output of java -version was just as below:

openjdk 11.0.6 2020-01-14
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.6+10)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.6+10, mixed mode)

There's no "version" between "openjdk" and "11.0.6", and the major version would be recognized as 0.

Originally reported by microsoft/vscode-java-pack#309 (comment)

@Eskibear
Copy link
Contributor Author

According to adoptium/temurin-build#1610 (comment) , it should always have "version" there. It's not clear what was happening on the user's machine. I don't think further actions need to be taken now, let's keep an eye on it.

@fbricon
Copy link
Collaborator

fbricon commented Sep 28, 2020

Closed with #1635

@fbricon fbricon closed this as completed Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants