Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get and Set method generation through intellicode generates javadoc when shouldn't #1411

Closed
cesarrew opened this issue Apr 26, 2020 · 2 comments
Assignees
Milestone

Comments

@cesarrew
Copy link

Get and Set method generation through intellicode generates javadoc as well, even with the property "java.codeGeneration.generateComments" defined as "false".

Environment
  • Operating System: Ubuntu 19.10
  • JDK version: openjdk 11.0.7 2020-04-14
  • Visual Studio Code version: 1.44.2
  • Java extension version: 0.60.0
  1. Create a POJO Java Class
  2. Define an attribute
  3. Using intellicode, generate get or set method for the attribute.

code_generation_get_set

@fbricon fbricon added the bug label May 6, 2020
@fbricon
Copy link
Collaborator

fbricon commented May 6, 2020

The language server has different ways of creating methods, typically this setting is respected only when calling the Generate Getters/Setters source action. This is a discrepancy we definitely need to fix.

@fbricon fbricon self-assigned this May 6, 2020
@fbricon fbricon added this to the Mid May 2020 milestone May 6, 2020
@fbricon
Copy link
Collaborator

fbricon commented May 6, 2020

eclipse-jdtls/eclipse.jdt.ls#1437 should fix it

@fbricon fbricon closed this as completed May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants